Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[technical] refractor provider abstraction #100

Closed
madiele opened this issue Sep 10, 2023 · 1 comment
Closed

[technical] refractor provider abstraction #100

madiele opened this issue Sep 10, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed rust Pull requests that update Rust code

Comments

@madiele
Copy link
Owner

madiele commented Sep 10, 2023

I'm not satisfied by my first attempt at it, I tested it's power by implementing one new provider and found it pretty leaky of it's internals.

With this I would like to open the path to redesign the flow, so that changes to apis or other provider specific weirdness could be handled.

The requirements for a provider are this

  • declare what urls are supported
  • feed generation based on an url
  • get the stream url based on a key
  • given a media key give a duration (needed for seeking to work)

The documentation will also ask to cache the data with redis when possible

This will mean provider will have some duplicated code in them, that is fine it will allow for better flexibility, it will also still use other services to get the actual rss but the next steps will be to kill this dependencies and do all the parsing in rust to improve performance and easier updates in case API invetably change

@madiele madiele added enhancement New feature or request help wanted Extra attention is needed rust Pull requests that update Rust code labels Sep 10, 2023
@madiele
Copy link
Owner Author

madiele commented Sep 10, 2023

I've added the help wanted to mostly open up to possible discussion on how to design the new abstraction.

I ideally hope to get it done by end of September, if I do i will open the project to hacktoberfest and give the option to implement new providers or refractor the one already there to people, might be fun

@madiele madiele closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

1 participant