Data Race in bvh.hpp

[ghost]

Using the Coderrect Scanner coderrect.com I discovered a data race in bvh.hpp between line 42 and itself.

 40|
 41| BoundingBoxProxy& operator = (const BoundingBox<Scalar>& bbox) {
>42|     node.bounds[0] = bbox.min[0];
 43|     node.bounds[1] = bbox.max[0];
 44|     node.bounds[2] = bbox.min[1];

[madmann91]

Hello, and thank you for the report. The information you gave above is not nearly enough to determine where the problem happens, or if there is even a problem to speak of. Could you first make sure you have the latest version of the library, then list your platform/OS, and provide some code to reproduce the issue? Without that, there's hardly anything I can do on my end to fix this problem, if it turns out that it does indeed exist.

[madmann91]

After some investigation, it seems you have quite the collection of issues reported on various projects. All have the same pattern: You "discovered" some data race somewhere using that tool. See for instance:

manodeep/Corrfunc#255
ParRes/Kernels#585
kimwalisch/primecount#42

Given that:

1. This library is tested on multiple platforms, with machines with up to 32 threads/16 cores,
2. You literally have no useful information (that line number is clearly not useful nor meaningful, since that method is called from many possible places),
3. You have a history of using open-source projects to test a commercial tool,
4. All of your "issues" on other projects end up being just false positives,

I have strong doubts about your "issue".

Thus, I have decided to remove this. Come back when you have data, some basic test case, and some background on the topic. And for the love of all that is good please stop wasting people's time with bug reports like this, and do at least a bit of investigation yourself. This type of behavior (using the open-source community's time to do your testing/debugging for free) is despicable.