Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonized_dossier_visualize() report shows variable labels in English but categories in French #29

Open
zchenmr opened this issue Oct 24, 2023 · 9 comments
Labels
documentation Improvements or additions to documentation to test

Comments

@zchenmr
Copy link

zchenmr commented Oct 24, 2023

R Maelstrom: Rmonize 1.0.0.9004, madshapR 1.0.2.9004, fabR 2.0.0

The "Variables summary" of harmonized_dossier_visualize() automatically displays variable labels in English but category labels in French when labels in both languages are available:
image

For individual harmonized variables, both variable labels are included but only the French category labels are displayed:
image

image

Input DataSchema (variables and categories):
image

image

@GuiFabre GuiFabre added the good first issue Good for newcomers label Oct 24, 2023
@GuiFabre GuiFabre pinned this issue Oct 26, 2023
GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Oct 27, 2023
@GuiFabre
Copy link
Contributor

The solution might not work for all the cases, but we will see ;)

@GuiFabre GuiFabre unpinned this issue Oct 27, 2023
@zchenmr
Copy link
Author

zchenmr commented Oct 27, 2023

"Variables summary" is now showing the English variable and category labels by default, but the category labels in the individual harmonized variable summaries (including figures) are still in French:

image image

@zchenmr
Copy link
Author

zchenmr commented Oct 31, 2023

R Maelstrom: Rmonize v1.0.0.9008, madshapR v1.0.2.9009, fabR 2.0.0

The French category labels for individual harmonized variables are still showing up in the visual report for me instead of the English labels. Maybe it's due to something in my configuration files or in the pre-processing steps prior to harmonization?

image

GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Nov 1, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 1, 2023

thank you again for your contribution. The bug was in madshapR

image

This should work now !

@zchenmr
Copy link
Author

zchenmr commented Nov 1, 2023

Yes, it's mostly working now! The individual harmonized variable summaries now show the labels in the same language consistently. However, when I swapped the columns "label:en" and "label:fr" in the Variables tab of the DataSchema (so that "label:fr" is on the left), the Variables summary of the report still has differing languages:

image

image

@GuiFabre GuiFabre pinned this issue Nov 1, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 2, 2023

indeed. that will stay like that:

the user may have the same order in Variables and Categories (:en, then :fr for both of them). But for any reason, them might also want them backward. So for that reason, the first label (:fr here) in Variable is taken, but also the first label (:en there) in Categories. If it seems backward to them, then they need to arrange them accordingly

@zchenmr
Copy link
Author

zchenmr commented Nov 2, 2023

Okay, that works. I do think there's still some inconsistency in the report in that case, since "Variables summary" shows the category labels in English (since it's the leftmost column in the DataSchema) but then in the individual harmonized variable summaries, all of the category labels are in French. It might also be a good idea to include a note in the documentation about column order so that users know to arrange the columns in the proper order.

image image

DS - Variables:
image

DS - Categories:
image

@GuiFabre GuiFabre added documentation Improvements or additions to documentation next version and removed good first issue Good for newcomers to test labels Nov 2, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 2, 2023

thank you, to be discussed for another version

@GuiFabre GuiFabre unpinned this issue Nov 2, 2023
@GuiFabre
Copy link
Contributor

GuiFabre commented Oct 8, 2024

This issue is related to what we are doing about the update of the summary and assessment report. I am just pushing this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation to test
Projects
None yet
Development

No branches or pull requests

2 participants