Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harmonized_dossier_visualize() report treats % NA as proportion #31

Closed
zchenmr opened this issue Nov 1, 2023 · 2 comments
Closed

harmonized_dossier_visualize() report treats % NA as proportion #31

zchenmr opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working to test

Comments

@zchenmr
Copy link

zchenmr commented Nov 1, 2023

R Maelstrom: Rmonize 1.0.0.9008, madshapR v1.0.2.9010, fabR 2.0.0

In the output report of harmonized_dossier_visualize, the summary statistics for individual harmonized variables show a % NA value that seems to have been treated like a proportion and multiplied by 100, leading to incorrect values.

image
@GuiFabre GuiFabre mentioned this issue Nov 1, 2023
Closed
@GuiFabre GuiFabre added the bug Something isn't working label Nov 1, 2023
@GuiFabre GuiFabre pinned this issue Nov 1, 2023
@GuiFabre GuiFabre mentioned this issue Nov 1, 2023
Closed
GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Nov 2, 2023
@GuiFabre
https://github.com/maelstrom-research/Rmonize/issues/31
24a94f3
@GuiFabre
Copy link
Contributor

GuiFabre commented Nov 2, 2023

done

image

@zchenmr
Copy link
Author

zchenmr commented Nov 2, 2023

I checked and this has been resolved:
image

@GuiFabre GuiFabre closed this as completed Nov 2, 2023
@GuiFabre GuiFabre unpinned this issue Nov 2, 2023
@GuiFabre GuiFabre mentioned this issue Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working to test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuiFabre @zchenmr