Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on readable-stream #23

Closed
JustinBeckwith opened this issue Nov 26, 2018 · 5 comments
Closed

Drop dependency on readable-stream #23

JustinBeckwith opened this issue Nov 26, 2018 · 5 comments

Comments

@JustinBeckwith
Copy link

JustinBeckwith commented Nov 26, 2018

It feels like the implementation of streams in Node.js 6+ has settled down a great deal. Would you consider a PR to drop the dependency on the user space implementation of readable-stream? Or are there good reasons to keep on using it?

@phated
Copy link
Collaborator

phated commented Nov 26, 2018

https://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html

@phated phated closed this as completed Nov 26, 2018
@phated phated reopened this Nov 26, 2018
@JustinBeckwith
Copy link
Author

Thanks! I totally understand the advantage of the readable-stream package.. a few years ago :) A lot of what Rod wrote about was true in the pre-4.x world. As of today though, I'd argue that streams have settled. The API seems fairly locked in, and functionality is pretty much the same across Node 6 => 11 AFAICT. I am absolutely not the expert here though :)

@mafintosh
Copy link
Owner

Being part of the streams working group readable-stream is still very much needed as there and bigger changes still happening underneat the hood of streams

@JustinBeckwith
Copy link
Author

Thanks! Can you give a TL;DR of what those changes look like? We're trying to evaluate our usage of streams across all of the Google npm modules, and I find myself often conflicted 😁

@phated
Copy link
Collaborator

phated commented Nov 27, 2018

I'll let mafintosh speak to changes but I'm going to close this so it doesn't show up on my github dashboard.

@phated phated closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants