How to get notified when done extracting?

[callumlocke]

I can't get the "DONE!" to print out here (even though tar-fs successfully extracts the whole tar):

fs.createReadStream('./my-file.tar')
  .pipe(tar.extract('./my-dir'))
  .on('error', function(err) {
    console.error('ERROR', err);
  })
  .on('end', function() {
    console.log('DONE!');
  });

I've also tried listening for finish instead of end (as I saw that name used in your tests) but that doesn't work either. Not sure what I'm doing...

[callumlocke]

I worked out I need to listen for the finish event on the tar.extract() part instead:

fs.createReadStream('./my-file.tar')
  .pipe(
    tar.extract('./my-dir')
      .on('finish', function () {
        console.log('DONE!');
      })
  )
  .on('error', function (err) {
    console.error('ERROR', err);
  })
  .on('end', function () {
    console.log('THIS NEVER FIRES');
  });

The original stream's end event is never fired. I'm guessing this is because there are extra bytes at the end of the tar that tar.extract doesn't need to read, so it just stops listening for its data events? Don't know if this is a bug. Please close this if not.

[mafintosh]

The extract stream does not emit finish since it's a writable stream. The pack stream emits end though (since its readable)

[callumlocke]

The extract stream does not emit finish since it's a writable stream.

? but finish does fire, in my example

[mafintosh]

doh. I meant:

The extract stream does not emit end since it's a writable stream. The pack stream emits end though (since its readable)

[callumlocke]

ah cool :) so this is right then