Cleanup session.Manager's handling of errors. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that cdp.ErrorCause tracks the list of causes and returns the true cause of the problem. In the case of bug mafredri#120, the topmost err was internal.OpError, and the ErrorCause returns underlying websocket.CloseError. Actually there's rpcc.closeError in the middle of cause chain, but that's simply skipped, and therefore it fails to recognize the error as closing. This tracks of every step of Cause and return true if any of these errors are closing one.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
========================================
+ Coverage 85.6% 85.8% +0.2%
========================================
Files 20 20
Lines 1019 1020 +1
========================================
+ Hits 872 875 +3
+ Misses 114 112 -2
Partials 33 33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that cdp.ErrorCause tracks the list of causes and
returns the true cause of the problem. In the case of bug #120,
the topmost err was internal.OpError, and the ErrorCause returns
underlying websocket.CloseError.
Actually there's rpcc.closeError in the middle of cause chain,
but that's simply skipped, and therefore it fails to recognize
the error as closing.
This tracks of every step of Cause and return true if any of
these errors are closing one.