Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributor Highlights in the docs #6

Open
DavidLambauer opened this issue Jul 3, 2023 · 7 comments
Open

Add Contributor Highlights in the docs #6

DavidLambauer opened this issue Jul 3, 2023 · 7 comments
Assignees

Comments

@DavidLambauer
Copy link
Contributor

CleanShot 2023-07-03 at 10 09 22@2x CleanShot 2023-07-03 at 10 09 30@2x CleanShot 2023-07-03 at 10 09 42@2x
@DavidLambauer
Copy link
Contributor Author

We currently have a Table of Contents Markdown Extension, which allows us to put [TOC] directly into an MD file and generate a proper table of contents.

I'd love to have a similar mechanism for the contributor highlights. A highlight must contain the contributor's name and link to his GitHub Account.

Something like [highlight, @DavidLambauer] would be nice

This is a good starting point: https://commonmark.thephpleague.com/2.4/extensions/mentions/

@laurali123
Copy link

Hey @nlardev-hublot ,
we have made some design suggestions for the contributor part (if it's not too late - how far have you already come?)
Feel free to look at them and tell us what you think and if you can manage to implement them?

1. Top Section

  • Add text field
  • the text is in cursive and color #ff6700
  • the text has an anchor link that scrolls to the end of the page to the new added section "contributor"
  • Add an icon in the navigation section: https://shorturl.at/sEGKL
  • Set a anchor link on the icon that scrolls you to the end of the page where a contributor section is found
image

2. Bottom Section Contributor

  • Add a contributor content block where a short "thanks"-sentence shows up
  • Place a contributor gitlab section underneath it
  • Get dynamically the gitlab users' profile image and company name
image

3. Bottom Section - Give a thanks to the contributor

  • Add a text block
  • Place beside it a "thank you" section where the readers can leave a "thank you" by clicking on the icon/button
  • After users have clicked on the button, the buttons counter addes for each click a number to visualize how many people have stayed "thanks"
  • we even thought of animations after clicking the "thanks" icon, like the hand-icon flying through the screen (but that's really fancy, I know... :D )
image

@nikolalardev
Copy link
Contributor

Thank you @laurali123 will work on it.

@nikolalardev
Copy link
Contributor

@DavidLambauer @laurali123
1. Top Section

  • I will need the icon in svg format to be able to add it. The svg download is not free :(

2. Bottom Section Contributor

3. Bottom Section - Give a thanks to the contributor

  • At the moment the documentation website is without database, we should find way to keep the "thanks" counter somewhere. @DavidLambauer

@DavidLambauer
Copy link
Contributor Author

HI @nikolalardev, I will provide a token once it is merged.

Name and Company field can be empty in github account of the user, if name is empty we can display username.

Good!

Should I used this design for images https://mage-os.org/about/contributors/

Yes, why not!

For the "Thanks" Section, it might be clever to just refer to get a membership of Mage-OS instead of having these clapping hands. The counter doesn't add any value and this would be a good opportunity to highlight the memberships more a bit.

@DavidLambauer
Copy link
Contributor Author

@laurali123 You take care of the SVG, yeh?

@laurali123
Copy link

@nikolalardev I changed the icon to a similar one, which is available for free, has no copyright and comes as a SVG file:
https://www.svgrepo.com/svg/49757/clap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants