-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM - Dominaria set card implementation tracking #4643
Comments
|
I updated the to do list |
Hello all, newbie here, quick question just to make sure: If I am working on one of the cards not yet done I simply check its box in the second post with In Progress before them, right? In other words, those with unchecked boxes in that post do not have anyone else working on them yet, correct? |
Yes, correct. |
A’ight, thanks. |
Sanctum Spirit -- done #4765 |
Dark Bargain -- done #4766 |
Since I can’t seem to mark the checkboxes here are the cards that I am currently working on: |
Gift of Growth -- done #4768 Apologies @BrewBrewBrewTheDeck, didn't see. |
@rscoates No worries, I am completely new here so if anyone so desires just do the ones I listed. For now I have yet to figure out how to even properly test the cards I did. @LevelX2 helped me with this earlier but so far we couldn’t determine what went wrong. The issue is that the cards I added showed up in-game (in the deck editor) but had no oracle text when hovering over them. Like, they’re just blank in that area. The cards themselves were fine, I think, but maybe I missed something. If you wanna look over my version of Gift of Growth, for example, this is it: Level glanced over it and saw nothing out of the ordinary. But perhaps the error lies with the file itself after all and you can spot it. Or know what else might result in that issue. Deleting the cards*.db files and checking the Force Cardbase Update checkbox in the client did not resolve it. |
Working on: |
Orcish Vandal -- done #4774 |
Starting on: |
Slinn Voda is already done, I just pushed it. |
Working on Aryel, Knight of Windgrace |
Take a look at Minamo Sightbender and Merchant's Dockhand. It's kinda tricky. |
@theelk801 Yes, thank you. Minamo Sightbender was a big help. Not quite there but it's coming together. And Merchant's Dockhand really quite useful for the part I'm on now. |
Done/Need an experienced developer to check: |
I gave it a glance, I'll look into it more soon. If you tested it and it works, it's probably fine, but the main thing to check is whether something like Experiment Kraj or Quicksilver Elemental is able to properly copy its ability. |
Working on: I'm on a bad computer with only an IDE, but I think this is right - please test before merging! |
Working on: Still struggling with Healing Grace, grateful for help / someone to take it on. |
I'll do Healing Grace |
Thanks @theelk801. Much appreciated. I realise it's now merged, but it doesn't look like your merge requires you to specify the source of the damage? That was my difficulty, so I appreciate it's hard, but it currently doesn't work as worded. |
Firesong and Sunspeaker -- #4792 (Have to leave work, can finish on return home, think it's very close. Not tested.) |
Elfhame Druid: #4791 |
I have some minor fixes to Aryel, Knight of Windgrace PR: #4793 However, I'm very new to this, and the card does not work. I hope that I at least provided a good base to make the work easier. |
Fixing up firesong: #4794 |
I don't know if you guys want this, but here is a list of cards that for various reasons do not show up in the client (in mine anyway). I put stars next to commons and uncommons that are good to great in limited and thus somewhat important for those practicing for prerelease events: |
@jack-the-BOSS - sure you have, but just in case... have you tried deleting the cards*.db files and/or checking the Force Cardbase Update checkbox in the client? These look like the last few to get finished and it may be a caching issue. I definitely had Jaya Ballard come up for me today, as one I can remember. |
@jack-the-BOSS update to latest xmage source code. I'm fixed yesterday some card errors (loading problem). And clean up all db-dirs (client and server) to re-create cards. |
@rscoates Good point, not since yesterday. |
By the way, everything else works fine with her. |
And when do you guys think there’ll be a fix? |
@RMFDEMON |
Hey, on the new version it still don't work. |
I don't know if it's because if it's fast mana. |
Plus in both cases I had at least 1 manamorphose in my graveyard. |
Actually it might be because I was also online and there were 2 on the field. |
Because it works with 1 on the field I guess. |
@RMFDEMON, i tried here, and works fine for me, i using the last version, 1.4.32V0. |
All Sets
https://magic.wizards.com/en/products/dominaria
Unimplemented cards
Cards in set:
The text was updated successfully, but these errors were encountered: