Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation not releasing memory #68

Closed
djtrip opened this issue Apr 2, 2020 · 2 comments
Closed

evaluation not releasing memory #68

djtrip opened this issue Apr 2, 2020 · 2 comments

Comments

@djtrip
Copy link

djtrip commented Apr 2, 2020

I noticed that the evaluate_or_sample function doesn't release memory between checkpoints.

For example, if I run ddsp_run in eval mode while another ddsp_run is training, the size of the evaluation process keeps growing as it loads and evaluates the checkpoints that are being generated by the training process. While killing and rerunning the eval process solves the issue, it is not an ideal solution.

@djtrip djtrip changed the title evaluation not releasing memmory evaluation not releasing memory Apr 2, 2020
@jesseengel
Copy link
Contributor

That's an interesting issue, we haven't run into it before. Are you running eval and training on a single machine? Our setups all run on separate instances reading/writing on a shared filespace. It's fairly straightforward to set something like that up on cloud, with two instances using the same bucket.

@jesseengel
Copy link
Contributor

Just closing this because three aren't more details, but feel free to reopen if it's still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants