This repository has been archived by the owner on Jun 19, 2018. It is now read-only.
Update MagentoRootComponentsPlugin to the new Webpack 4 Tapable hooks system #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrien-louis-r Thank you so much, I totally missed this PR! I apologize for the delay, and I'll be looking at this as soon as I can. Thank you for contributing 😺 |
|
Blocked by magento-research/venia-pwa-concept#72 |
|
This PR will need to be re-targeted to the new monorepo. I'll take care of the work. Thanks again @adrien-louis-r! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This is an updated version of the MagentoRootComponentsPlugin compatible with the new Webpack 4 Tapable hooks system #19.
I'm no expert in Webpack, so that might not be the optimal hooks to use, but the tests are green :).