Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to webpack 4 #27

Closed
PWAStudioBot opened this issue Jun 13, 2018 · 3 comments
Closed

Upgrade to webpack 4 #27

PWAStudioBot opened this issue Jun 13, 2018 · 3 comments
Assignees
@zetlen
Labels
pkg:pwa-buildpack pkg:venia-concept tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs.
Milestone
Sprint 29

Comments

@PWAStudioBot
Copy link
Contributor

From @DrewML on May 18, 2018 15:32

We're avoiding merging magento-research/pwa-buildpack#21 until this project has been upgraded. This will likely require upgrading some plugins and modifying the config in webpack.config.js.

Acceptance Criteria:

  • Project builds and runs on the latest release of webpack 4.

Copied from original issue: magento-research/venia-pwa-concept#72
@PWAStudioBot PWAStudioBot mentioned this issue Jun 13, 2018
Closed
@DrewML DrewML added help wanted Eligible for community contribution. tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. pkg:pwa-buildpack pkg:venia-concept labels Jun 14, 2018
@zetlen
Copy link
Contributor

zetlen commented Sep 26, 2018

Addressed by #301.

@zetlen zetlen self-assigned this Sep 26, 2018
@ericerway
Copy link

@zetlen moving this to Review/QA based on the progress this week and removing "help wanted". Let me know when this is ready to merge. Thanks!

@ericerway ericerway removed the help wanted Eligible for community contribution. label Sep 27, 2018
@ericerway ericerway added this to the Sprint 29 milestone Nov 6, 2018
@zetlen
Copy link
Contributor

zetlen commented Nov 9, 2018

Closed by #301

@zetlen zetlen closed this as completed Nov 9, 2018
fnhipster pushed a commit to PMET-public/pwa-studio that referenced this issue Apr 9, 2019
@jimbo
Add tests for utils (magento#27)
f030153 
* Write tests for utils

* Change caching strategy for gallery images
fnhipster pushed a commit to PMET-public/pwa-studio that referenced this issue Apr 9, 2019
@zetlen
Dependency update to fix vulnerabilities (magento#27)
8e2fdb9 
* style: apply prettier 1.12.1 new rule

* update package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zetlen zetlen

Labels
pkg:pwa-buildpack pkg:venia-concept tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs.
Projects
None yet
Milestone
Sprint 29
Development

No branches or pull requests
4 participants
@zetlen @ericerway @DrewML @PWAStudioBot