fix(ci): Configure CircleCI to build release and master. #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
|
OK, so far this isn't working, because the integration workflow is running on it, which isn't supposed to happen. |
zetlen
force-pushed
the
zetlen/fix-integration-ci-builds-1042
branch
from
8b3b304
to
f5b5702
Compare
|
Figured that out. Typo in the YAML anchor reference. |
sirugh
reviewed
Mar 20, 2019
| filters: | ||
| branches: | ||
| only: master | ||
| only: *integration_branches |
There was a problem hiding this comment.
How does CircleCI know what integration_branches are?
There was a problem hiding this comment.
That's a back reference to the array above on L9.
There was a problem hiding this comment.
That's a YAML anchor reference to the YAML anchor defined above with &integration_branches.
jimbo
approved these changes
Mar 20, 2019
sirugh
added
the
tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change CircleCI config to more clearly delineate between pull request builds and integration builds:
buildworkflow toprandmasterworkflow tointegration.integrationworkflow runs onmaster,develop, andrelease/x.xbranches (using a regular expression for the latter)buildworkflow excludes those same branchesRelated Issue
Closes #1042.
Motivation and Context
Releasing 2.1 and future releases.
Verification
Make sure CircleCI builds for this PR behave as expected, but we won't know for sure until we merge it, due to the nature of CircleCI.
Proposed Labels for Change Type/Package
BUG for CI workflow.
Checklist: