Fixed #901

[pradeep-cedcoss]

Fixed #901 Cart flashes/reloads twice when last cart item is removed.

Description:
Add product to cart and click on Remove Item link > Cart flashes (Shows "There are no item in your cart" now displays Loading spinner and back to ""There are no item in your cart"" )

Steps to reproduce the behavior:

Go to Venia storefront and add a product to cart.
Now click on Remove Item option present under more options (3 vertical dots).
Expected behavior:
Shopping Cart right drawer should be displayed with "There are no items in your shopping cart" message with Continue shopping button.

Actual:
Shopping Cart right drawer displays message then shows loading icon and displays message. This behavior needs to be changed.

Checklist:

• I have updated the documentation accordingly, if necessary.
• I have added tests to cover my changes, if necessary.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-fork-pradeep-cedcoss-pradeep-pwa-901-new.magento-research1.now.sh

[tjwiebell]

Change functions perfectly, just have some minor suggestions for readability.

Addressed my own feedback, re-assigning review

[supernova-at]

This makes sense to me and works fine.

The only thing I can think of is last time we did something like this we were worried about the cart being updated from a separate tab and we purposefully wanted to refresh so that we could get that update.

After thinking it through I don't think that applies here. Let me know if you think otherwise.

[dpatil-magento]

@tjwiebell @supernova-at I remove last item from cart > Close right panel> click back on cart icon. First empty cart is shown then reload then back to empty cart. Should it be just reload and then show empty cart?
BTW, I re-run AWS pwa-pull-request-build and it passed, ran build locally too it works, so the failure might just be an odd one.

[tjwiebell]

@tjwiebell @supernova-at I remove last item from cart > Close right panel> click back on cart icon. First empty cart is shown then reload then back to empty cart. Should it be just reload and then show empty cart?
BTW, I re-run AWS pwa-pull-request-build and it passed, ran build locally too it works, so the failure might just be an odd one.

The initial render, then loading indicator, then re-render seems like a regression to me, I'll look into it.

[dpatil-magento]

@supernova-at QA Pass, Please review latest commit and merge.