Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase history data fetching #439

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

Starotitorov
Copy link
Contributor

@Starotitorov Starotitorov commented Oct 31, 2018

This PR is a:

[x] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

Implement data fetching for purchase history page #294 on mocks.

Additional information

@vercel
Copy link

vercel bot commented Oct 31, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 31, 2018

Fails
🚫

The following file(s) were not formatted with prettier. Make sure to execute npm run prettier locally prior to committing.

packages/venia-concept/src/components/PurchaseHistoryPage/PurchaseHistory/purchaseHistory.js

Generated by 🚫 dangerJS

@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch 3 times, most recently from 642d31b to 8ce3fc7 Compare October 31, 2018 12:23
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch 3 times, most recently from f70410c to 35ae2f0 Compare November 5, 2018 13:53
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch from 35ae2f0 to bfe746e Compare November 12, 2018 12:54
@Starotitorov Starotitorov removed the request for review from AlexeyKaryka November 12, 2018 13:16
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch from d8f2312 to 83c4dbf Compare November 14, 2018 12:27
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch from 83c4dbf to 8a9fc48 Compare November 14, 2018 12:53
@coveralls
Copy link

coveralls commented Nov 14, 2018

Coverage Status

Coverage increased (+0.5%) to 17.504% when pulling bc7cb99 on feature/purchase-history-data-fetching into 4a55b98 on release/2.0.

@Starotitorov Starotitorov force-pushed the feature/purchase-history-page branch 2 times, most recently from 14ca9b0 to 81bf20a Compare November 16, 2018 13:19
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch 2 times, most recently from 113ece3 to 184bdf7 Compare November 16, 2018 13:33
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch from 184bdf7 to 6fdcadf Compare November 20, 2018 09:25
@Starotitorov Starotitorov force-pushed the feature/purchase-history-data-fetching branch from 6fdcadf to 72791ea Compare November 21, 2018 09:47
@Starotitorov Starotitorov changed the base branch from feature/purchase-history-page to release/2.0 November 21, 2018 09:48
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Going to test it real quick. 👍

@jimbo jimbo merged commit 9f45a09 into release/2.0 Nov 30, 2018
@jimbo jimbo deleted the feature/purchase-history-data-fetching branch November 30, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants