This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#31 CMS page/block coverage #105

Merged

magento-engcom-team merged 33 commits into 2.3-develop from 31-cms-page-graphql-support

Sep 11, 2018

Member

roma-glushko commented Jun 30, 2018 •

edited by TomashKhamlai

Loading

Description

PR enables to fetch CMS pages via GraphQL entry point. The following stuff is available:

Only enabled pages will be returned by the API
Store view context is passed in the HTTP header and only pages relevant to given context will be returned

API returns the following info:

url key
layout
page title
content heading
meta title, keywords, description

Fixed Issues (if relevant)

CMS page coverage #31: CMS page coverage

Manual testing scenarios

Using ChromeiQL, it's possible to send the following query:

  cmsPage(id: 1) {
    url_key
    title
    content
    content_heading
    page_layout
    meta_title
    meta_description
    meta_keywords
  }
}

Roman Glushko added 2 commits

June 30, 2018 14:36


          #31 Inited a new module and implement a basic support of CMS page ent…

a617b80

…ry point for GraphQL


          #31 Removed ID from array

94c904e

roma-glushko self-assigned this

Contributor

magento-cicd2 commented Jun 30, 2018 •

edited

Loading

All committers have signed the CLA.

roma-glushko mentioned this pull request

CMS page coverage #31

Closed

Roman Glushko added 6 commits

June 30, 2018 15:54


          #31 Made it possible to return active pages only

9b26913


          #32 Inited a new graph QL module that enables support of CMS blocks API

e17c536


          #32 Changed exception to throw

a7f0871


          #31 Refactored the code & committed composer.lock

1f9c09e


          #32 Refactored the code

0e2a2a6


          #31 Refactored module

85e6826

paliarush added requires-documentation requires-tests labels

keharper mentioned this pull request

Document GraphQL CMS endpoint magento/devdocs#2403

Closed

12 tasks

Roman Glushko added 2 commits

July 2, 2018 23:35


          #32 Fixed code styling

c776df6


          #31 Refactored the code

f35af8b

DrewML reviewed

View reviewed changes

app/code/Magento/CmsGraphQl/Model/Resolver/Cms/CmsPageDataProvider.php Outdated

+                          'page_content' => $cmsPageModel->getContent(),
+                          'content_heading' => $cmsPageModel->getContentHeading(),
+                          'layout' => $cmsPageModel->getPageLayout(),
+                          'mate_title' => $cmsPageModel->getMetaTitle(),

DrewML Jul 3, 2018

Small typos. mate >> meta

roma-glushko added the in-progress label

Roman Glushko and others added 5 commits

July 14, 2018 13:00


          #32 Added strict typing to bootstrap file


          #31 Fixed typo

48fa7b5


          #31 Removed the line

5552cdc


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

874f564

…aphql-support

# Conflicts:
#	composer.lock


          GraphQL-31: CMS page coverage

eb1ed7a

naydav removed the in-progress label

Valeriy Nayda added 3 commits

July 19, 2018 13:18


          Merge branch '31-cms-page-graphql-support' into 32-cms-block-graphql-…

3bdd690

…support

# Conflicts:
#	app/code/Magento/CmsGraphQl/etc/module.xml
#	app/code/Magento/CmsGraphQl/etc/schema.graphqls
#	composer.lock


          GraphQL-32: CMS block coverage

02ab4bf


          Merge pull request #109 from magento/32-cms-block-graphql-support

dce6c11

#32 CMS block coverage

naydav changed the title ~~#31 CMS page coverage~~ #31 CMS page/block coverage

magento-engcom-team assigned naydav

magento-engcom-team added this to the Release: 2.3.0 milestone


          #31 Imported dependencies

1f2e6fa

roma-glushko mentioned this pull request

[Commerce] CMS block coverage #111

Closed

Valeriy Nayda added 2 commits

August 9, 2018 15:57


          GraphQL-31: CMS page coverage

dacd786


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

3eeb28f

…aphql-support

# Conflicts:
#	composer.lock

naydav force-pushed the 31-cms-page-graphql-support branch from a9a332b to 2cb2705 Compare

August 13, 2018 12:23

Valeriy Nayda added 2 commits

August 13, 2018 16:07


          GraphQL-31: CMS page coverage

23567bc

-- Update composer json


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

c5ecc0c

…aphql-support

naydav force-pushed the 31-cms-page-graphql-support branch from 2cb2705 to c5ecc0c Compare

August 13, 2018 13:08

Valeriy Nayda added 3 commits

August 13, 2018 17:28


          GraphQL-31: CMS page coverage

68fafd7

-- Update composer json


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

…aphql-support

# Conflicts:
#	composer.lock


          GraphQL-31: CMS page coverage

01c5a3d

-- Update composer json

magento-engcom-team added the Release Line: 2.3 label

Valeriy Nayda added 3 commits

August 15, 2018 16:55


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

0091c4e

…aphql-support


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

122fc46

…aphql-support

# Conflicts:
#	composer.lock


          GraphQL-31: CMS page coverage

8ac4471

-- Update composer lock

TomashKhamlai mentioned this pull request

Test coverage for CMS page/block #151

Closed

Valeriy Nayda added 3 commits

August 27, 2018 13:34


          Merge remote-tracking branch 'origin/2.3-develop' into 31-cms-page-gr…

7ee4000

…aphql-support

# Conflicts:
#	composer.lock


          GraphQL-31: CMS page coverage

709a1f7

-- Update composer lock


          GraphQL-31: CMS page coverage

2966ac3

-- Update composer lock

This was referenced Sep 3, 2018

GraphQL modules delivery #165

Closed

GraphQL modules delivery #166

Merged

artKozinets mentioned this pull request

Show only active CMS Blocks #176

Closed

magento-engcom-team merged commit 2966ac3 into 2.3-develop

ronak2ram mentioned this pull request

Fixed #176 - Show only active CMS Blocks #193

Closed

4 tasks

This was referenced Oct 20, 2018

Fixed #176 - Show only active CMS Blocks #218

Closed

Fixed #176 - Show only active CMS Blocks #221

Merged

keharper added documentation-completed and removed requires-documentation labels

naydav deleted the 31-cms-page-graphql-support branch

April 12, 2019 19:33

magento-engcom-team pushed a commit that referenced this pull request


          Merge pull request #105 from magento-pangolin/MC-4459

cb30dd8

MC-4459

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.3-develop documentation-completed Imported Partner: Atwix partners-contribution Release Line: 2.3 requires-tests