Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

CMS page coverage #31

Closed
paliarush opened this issue May 17, 2018 · 2 comments
Closed

CMS page coverage #31

paliarush opened this issue May 17, 2018 · 2 comments

Comments

@paliarush
Copy link
Contributor

paliarush commented May 17, 2018

As a Magento Developer, I want to query for CMS page content using the GraphQL API so that I can build basic ecommerce storefronts using only GraphQL

Use cases:

  • Developer can query GraphQL for CMS page content and get back all necessary data to render the page on storefront or in 3rd party applications.

Acceptance Criteria

  • Only enabled pages will be returned by the API
  • Store view context is passed in the HTTP header and only pages relevant to given context will be returned
  • Staging versions of the page cannot be queried - only the currently active pages are returned
  • [DRAFT] API returns the following info
    • url or url key
    • layout
    • layout update XML?
    • theme?
    • page title
    • content heading
    • rendered (with no Magento-specific directives) or un-rendered page content, depending on configuration
    • meta title, keywords, description
    • parent page(s)

Changes should be covered with web API functional tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.

@paliarush paliarush added additional-coverage for-grooming This issue needs to be discussed before it can be worked on medium labels May 17, 2018
@misha-kotov misha-kotov removed the for-grooming This issue needs to be discussed before it can be worked on label Jun 21, 2018
@roma-glushko roma-glushko self-assigned this Jun 30, 2018
roma-glushko pushed a commit that referenced this issue Jun 30, 2018
roma-glushko pushed a commit that referenced this issue Jun 30, 2018
@roma-glushko
Copy link
Member

roma-glushko commented Jun 30, 2018

Hi @paliarush ,

I have implemented all stuff from requirements possible on Magento 2 Open Source. Some of them I had to avoid due to Commerce only features:

  • parent page(s)
  • rendered (with no Magento-specific directives) or un-rendered page content, depending on configuration (PageBuilder related stuff)

This is followed up in the following ticket: #106

Also, information under discussion is not added:

  • layout update XML
  • theme

PR: #105

Thanks!

@naydav
Copy link
Contributor

naydav commented Sep 11, 2018

#166

@naydav naydav closed this as completed Sep 11, 2018
magento-engcom-team pushed a commit that referenced this issue Oct 13, 2018
 - Merge Pull Request magento/bulk-api-ce#31 from magento/bulk-api-ce:async-delete
 - Merged commits:
   1. 069aa1c
   2. 694d219
@naydav naydav modified the milestone: Release: 2.3.1 Dec 7, 2018
magento-engcom-team added a commit that referenced this issue Jan 27, 2019
 - Merge Pull Request magento-commerce/async-import#31 from magento/async-import:swagger-cache-fix
 - Merged commits:
   1. dd1cdec
   2. dad84f4
   3. 56f3580
   4. cbcc5e8
   5. eecb01f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants