Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dependency on abandoned PHP_CodeSniffer tool #475

Closed
wants to merge 1 commit into from
Closed

Replace dependency on abandoned PHP_CodeSniffer tool #475

wants to merge 1 commit into from

Conversation

JosephLeedy
Copy link

Fixes #474

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 1, 2023
@JosephLeedy
Copy link
Author

I need to fix the Composer package lock, and it looks like I cannot do that until other tools (i.e. dealerdirect/phpcodesniffer-composer-installer, magento/php-compatibility-fork and phpcsstandards/phpcsutils are updated as well.

@jrfnl
Copy link

jrfnl commented Dec 7, 2023

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

@JosephLeedy
Copy link
Author

Thank you, Juliette. I'm withdrawing this pull request.

@JosephLeedy JosephLeedy closed this Dec 7, 2023
@m2-community-project m2-community-project bot removed this from Ready for Review in Pull Request Progress Dec 7, 2023
@JosephLeedy JosephLeedy deleted the implement-codesniffer-fork branch December 7, 2023 15:03
@JosephLeedy JosephLeedy mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace SquizLabs PHPCodeSniffer with Fork
2 participants
@JosephLeedy @jrfnl