ENGCOM-6964: Fix wrong type of argument appendSummaryFieldsToCollection

#26755
magento · Feb 25, 2020 · 0029cdc · 0029cdc
2 parents 9674607 + 1643897
commit 0029cdc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/code/Magento/Review/Model/ResourceModel/Review/Summary.php b/app/code/Magento/Review/Model/ResourceModel/Review/Summary.php
@@ -79,14 +79,14 @@ public function reAggregate($summary)
      * Append review summary fields to product collection
      *
      * @param \Magento\Catalog\Model\ResourceModel\Product\Collection $productCollection
-     * @param string $storeId
+     * @param int $storeId
      * @param string $entityCode
      * @return Summary
      * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function appendSummaryFieldsToCollection(
         \Magento\Catalog\Model\ResourceModel\Product\Collection $productCollection,
-        string $storeId,
+        int $storeId,
         string $entityCode
     ) {
         if (!$productCollection->isLoaded()) {

diff --git a/app/code/Magento/Review/Observer/CatalogProductListCollectionAppendSummaryFieldsObserver.php b/app/code/Magento/Review/Observer/CatalogProductListCollectionAppendSummaryFieldsObserver.php
@@ -53,7 +53,7 @@ public function execute(EventObserver $observer)
         $productCollection = $observer->getEvent()->getCollection();
         $this->sumResourceFactory->create()->appendSummaryFieldsToCollection(
             $productCollection,
-            $this->storeManager->getStore()->getId(),
+            (int)$this->storeManager->getStore()->getId(),
             \Magento\Review\Model\Review::ENTITY_PRODUCT_CODE
         );
 

diff --git a/...Review/Test/Unit/Observer/CatalogProductListCollectionAppendSummaryFieldsObserverTest.php b/...Review/Test/Unit/Observer/CatalogProductListCollectionAppendSummaryFieldsObserverTest.php
@@ -23,7 +23,7 @@
  */
 class CatalogProductListCollectionAppendSummaryFieldsObserverTest extends TestCase
 {
-    private const STORE_ID = '1';
+    private const STORE_ID = 1;
 
     /**
      * @var Event|MockObject