#bug-33486 - fixing integration tests for multiselect attributes stor…

…es in _text entity table
magento · Jul 18, 2021 · 2be10b7 · 2be10b7
1 parent 16ef8b1
commit 2be10b7
Show file tree

Hide file tree

Showing 10 changed files with 56 additions and 23 deletions.
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Model/ProductGettersTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Model/ProductGettersTest.php
@@ -215,16 +215,36 @@ public function testGetAttributeTextArray()
         $product = $this->productRepository->get('simple_ms_2');
         $product->getAttributeText('multiselect_attribute');
         $expected = [
-            'Option 2',
-            'Option 3',
-            'Option 4 "!@#$%^&*'
+            'Multiselect option 2',
+            'Multiselect option 3',
+            'Multiselect option 4'
         ];
         self::assertEquals(
             $expected,
             $product->getAttributeText('multiselect_attribute')
         );
     }
 
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/products_with_multiselect_attribute.php
+     */
+    public function testMultipleMultiselectValues()
+    {
+        $expectedArray = [];
+
+        for ($i = 1; $i < 200; $i++) {
+            $expectedArray[] = sprintf('Multiselect option %d', $i);
+        }
+
+        $product = $this->productRepository->get('simple_ms_3');
+
+        self::assertEquals(
+            $expectedArray,
+            $product->getAttributeText('multiselect_attribute')
+        );
+    }
+
+
     public function testGetCustomDesignDate()
     {
         $this->assertEquals(['from' => null, 'to' => null], $this->_model->getCustomDesignDate());

diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/multiselect_attribute.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/multiselect_attribute.php
@@ -12,6 +12,15 @@
 $attribute = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
     \Magento\Catalog\Model\ResourceModel\Eav\Attribute::class
 );
+
+$valueOptionArray = [];
+$orderArray = [];
+
+for ($i = 1; $i < 200; $i++) {
+    $valueOptionArray[sprintf('option_%d', $i)] = [sprintf('Multiselect option %d', $i)];
+    $orderArray[sprintf('option_%d', $i)] = $i;
+}
+
 $entityType = $installer->getEntityTypeId('catalog_product');
 if (!$attribute->loadByCode($entityType, 'multiselect_attribute')->getAttributeId()) {
     $attribute->setData(
@@ -34,21 +43,11 @@
             'used_in_product_listing' => 0,
             'used_for_sort_by' => 0,
             'frontend_label' => ['Multiselect Attribute'],
-            'backend_type' => 'varchar',
+            'backend_type' => 'text',
             'backend_model' => \Magento\Eav\Model\Entity\Attribute\Backend\ArrayBackend::class,
             'option' => [
-                'value' => [
-                    'option_1' => ['Option 1'],
-                    'option_2' => ['Option 2'],
-                    'option_3' => ['Option 3'],
-                    'option_4' => ['Option 4 "!@#$%^&*']
-                ],
-                'order' => [
-                    'option_1' => 1,
-                    'option_2' => 2,
-                    'option_3' => 3,
-                    'option_4' => 4,
-                ],
+                'value' => $valueOptionArray,
+                'order' => $orderArray
             ],
         ]
     );

diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_html.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_html.php
@@ -41,7 +41,7 @@
             'used_in_product_listing' => 0,
             'used_for_sort_by' => 0,
             'frontend_label' => ['Multiselect Attribute'],
-            'backend_type' => 'varchar',
+            'backend_type' => 'text',
             'backend_model' => ArrayBackend::class,
             'option' => [
                 'value' => [

diff --git a/...egration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_incorrect_values.php b/...egration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_incorrect_values.php
@@ -33,7 +33,7 @@
         'used_in_product_listing' => 0,
         'used_for_sort_by' => 0,
         'frontend_label' => ['Multiselect Attribute'],
-        'backend_type' => 'varchar',
+        'backend_type' => 'text',
         'backend_model' => \Magento\Eav\Model\Entity\Attribute\Backend\ArrayBackend::class,
         'option' => [
             'value' => [

diff --git a/.../integration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_source_model.php b/.../integration/testsuite/Magento/Catalog/_files/multiselect_attribute_with_source_model.php
@@ -34,7 +34,7 @@
             'used_in_product_listing' => 0,
             'used_for_sort_by' => 0,
             'frontend_label' => ['Multiselect Attribute with Source Model'],
-            'backend_type' => 'varchar',
+            'backend_type' => 'text',
             'backend_model' => \Magento\Eav\Model\Entity\Attribute\Backend\ArrayBackend::class,
             'source_model' => \Magento\Catalog\_files\MultiselectSourceMock::class
         ]

diff --git a/...ests/integration/testsuite/Magento/Catalog/_files/products_with_multiselect_attribute.php b/...ests/integration/testsuite/Magento/Catalog/_files/products_with_multiselect_attribute.php
@@ -54,3 +54,17 @@
     ->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
     ->setStockData(['use_config_manage_stock' => 1, 'qty' => 100, 'is_qty_decimal' => 0, 'is_in_stock' => 1])
     ->save();
+
+$product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(\Magento\Catalog\Model\Product::class);
+$product->setTypeId(\Magento\Catalog\Model\Product\Type::TYPE_SIMPLE)
+    ->setId($optionIds[2] * 10)
+    ->setAttributeSetId($installer->getAttributeSetId('catalog_product', 'Default'))
+    ->setWebsiteIds([1])
+    ->setName('With Multiselect 3')
+    ->setSku('simple_ms_3')
+    ->setPrice(10)
+    ->setVisibility(\Magento\Catalog\Model\Product\Visibility::VISIBILITY_BOTH)
+    ->setMultiselectAttribute(array_values($optionIds))
+    ->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
+    ->setStockData(['use_config_manage_stock' => 1, 'qty' => 100, 'is_qty_decimal' => 0, 'is_in_stock' => 1])
+    ->save();
diff --git a/dev/tests/integration/testsuite/Magento/Elasticsearch/Model/Adapter/ElasticsearchTest.php b/dev/tests/integration/testsuite/Magento/Elasticsearch/Model/Adapter/ElasticsearchTest.php
@@ -140,7 +140,7 @@ public function createNewAttribute(): void
                 'used_in_product_listing' => 0,
                 'used_for_sort_by' => 0,
                 'frontend_label' => ['Multiselect Attribute'],
-                'backend_type' => 'varchar',
+                'backend_type' => 'text',
                 'backend_model' => ArrayBackend::class,
                 'option' => [
                     'value' => [

diff --git a/dev/tests/integration/testsuite/Magento/Elasticsearch/_files/multiselect_attribute.php b/dev/tests/integration/testsuite/Magento/Elasticsearch/_files/multiselect_attribute.php
@@ -34,7 +34,7 @@
         'used_in_product_listing' => 0,
         'used_for_sort_by' => 0,
         'frontend_label' => ['Multiselect Attribute'],
-        'backend_type' => 'varchar',
+        'backend_type' => 'text',
         'backend_model' => \Magento\Eav\Model\Entity\Attribute\Backend\ArrayBackend::class,
         'option' => [
             'value' => [

diff --git a/dev/tests/integration/testsuite/Magento/Framework/Search/_files/filterable_attribute.php b/dev/tests/integration/testsuite/Magento/Framework/Search/_files/filterable_attribute.php
@@ -54,7 +54,7 @@
             'value' => ['option_0' => ['Option 1'], 'option_1' => ['Option 2']],
             'order' => ['option_0' => 1, 'option_1' => 2],
         ],
-        'backend_type' => 'varchar',
+        'backend_type' => 'text',
     ]
 );
 $multiselectAttribute->save();

diff --git a/dev/tests/integration/testsuite/Magento/Sales/_files/order_address_with_multi_attribute.php b/dev/tests/integration/testsuite/Magento/Sales/_files/order_address_with_multi_attribute.php
@@ -40,7 +40,7 @@
             'frontend_input' => 'multiselect',
             'frontend_label' => ['Multiselect Attribute'],
             'sort_order' => '0',
-            'backend_type' => 'varchar',
+            'backend_type' => 'text',
             'is_user_defined' => 1,
             'is_system' => 0,
             'is_required' => '0',