Skip to content

Commit

Permalink
Merge pull request #6242 from magento-tsg/2.4-develop-sidecar-pr4
Browse files Browse the repository at this point in the history
[Sidecar] Fixes for 2.4 (pr4)
  • Loading branch information
zakdma committed Oct 18, 2020
2 parents c0f3dfb + bfc1033 commit 32ed03c
Show file tree
Hide file tree
Showing 24 changed files with 1,433 additions and 81 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="StorefrontCheckPresentSubCategoryActionGroup">
<annotations>
<description>Checks for a subcategory in topmenu</description>
</annotations>
<arguments>
<argument name="parenCategoryName" type="string"/>
<argument name="childCategoryName" type="string"/>
</arguments>

<waitForElementVisible selector="{{StorefrontHeaderSection.NavigationCategoryByName(parenCategoryName)}}" stepKey="waitForTopMenuLoaded"/>
<moveMouseOver selector="{{StorefrontHeaderSection.NavigationCategoryByName(parenCategoryName)}}" stepKey="moveMouseToParentCategory"/>
<seeElement selector="{{StorefrontHeaderSection.NavigationCategoryByName(childCategoryName)}}" stepKey="seeSubcategoryInTree"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
<section name="AdminCategoryModalSection"/>
<section name="AdminCategoryMessagesSection"/>
<section name="AdminCategoryContentSection"/>
<section name="AdminCategoryScheduleDesignUpdateSection"/>
</page>
</pages>
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@
<element name="FieldError" type="text" selector=".admin__field-error[data-bind='attr: {for: {{field}}}, text: error']" parameterized="true"/>
<element name="panelFieldControl" type="input" selector="//aside//div[@data-index=&quot;{{arg1}}&quot;]/descendant::*[@name=&quot;{{arg2}}&quot;]" parameterized="true"/>
<element name="productsInCategory" type="input" selector="div[data-index='assign_products']" timeout="30"/>
<element name="scheduleDesignUpdateTab" type="block" selector="div[data-index='schedule_design_update']" timeout="15"/>
</section>
</sections>
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
<section name="AdminCategoryScheduleDesignUpdateSection">
<element name="sectionHeader" type="button" selector="div[data-index='schedule_design_update'] .fieldset-wrapper-title" timeout="30"/>
<element name="sectionBody" type="text" selector="div[data-index='schedule_design_update'] .admin__fieldset-wrapper-content"/>
</section>
</sections>
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,15 @@
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="AdminProductCategoryIndexerInUpdateOnScheduleModeTest">
<annotations>
<features value="Catalog"/>
<stories value="Product Categories Indexer"/>
<title value="Product Categories Indexer in Update on Schedule mode"/>
<description value="The test verifies that in Update on Schedule mode if displaying of category products on Storefront changes due to product properties change,
the changes are NOT applied immediately, but applied only after cron runs (twice)."/>
<severity value="BLOCKER"/>
<testCaseId value="MC-11146"/>
<severity value="CRITICAL"/>
<testCaseId value="MC-26119"/>
<group value="catalog"/>
<group value="indexer"/>
<skip>
<issueId value="MC-20392"/>
</skip>
</annotations>
<before>
<actionGroup ref="AdminLoginActionGroup" stepKey="LoginAsAdmin"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminSaveAndContinueWidgetActionGroup">
<annotations>
<description>Click on the Save an Continue button and check the success message</description>
</annotations>
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
<click selector="{{AdminNewWidgetSection.saveAndContinue}}" stepKey="clickSaveWidget"/>
<waitForElementVisible selector="{{AdminMessagesSection.success}}" stepKey="waitForSuccessMessageAppeared"/>
<see selector="{{AdminMessagesSection.success}}" userInput="The widget instance has been saved" stepKey="seeSuccess"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminSetWidgetNameAndStoreActionGroup">
<annotations>
<description>Set widget name, store IDs and sort order on Widget edit page</description>
</annotations>
<arguments>
<argument name="widgetTitle" defaultValue="{{ProductsListWidget.name}}" type="string"/>
<argument name="widgetStoreIds" defaultValue="{{ProductsListWidget.store_ids}}" type="string"/>
<argument name="widgetSortOrder" defaultValue="{{ProductsListWidget.sort_order}}" type="string"/>
</arguments>
<waitForElementVisible selector="{{AdminNewWidgetSection.widgetTitle}}" stepKey="waitForWidgetTitleInputVisible"/>
<fillField selector="{{AdminNewWidgetSection.widgetTitle}}" userInput="{{widgetTitle}}" stepKey="fillTitle"/>
<selectOption selector="{{AdminNewWidgetSection.widgetStoreIds}}" parameterArray="{{widgetStoreIds}}" stepKey="setWidgetStoreId"/>
<fillField selector="{{AdminNewWidgetSection.widgetSortOrder}}" userInput="{{widgetSortOrder}}" stepKey="fillSortOrder"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminSetWidgetTypeAndDesignActionGroup">
<annotations>
<description>Select type and design on Widget edit page</description>
</annotations>
<arguments>
<argument name="widgetType" defaultValue="{{ProductsListWidget.type}}" type="string"/>
<argument name="widgetDesign" defaultValue="{{ProductsListWidget.design_theme}}" type="string"/>
</arguments>
<waitForElementVisible selector="{{AdminNewWidgetSection.widgetType}}" stepKey="waitForTypeInputVisible"/>
<selectOption selector="{{AdminNewWidgetSection.widgetType}}" userInput="{{widgetType}}" stepKey="setWidgetType"/>
<selectOption selector="{{AdminNewWidgetSection.widgetDesignTheme}}" userInput="{{widgetDesign}}" stepKey="setWidgetDesignTheme"/>
</actionGroup>
</actionGroups>
1 change: 1 addition & 0 deletions app/code/Magento/Widget/Test/Mftf/Data/WidgetsData.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<data key="type">Catalog Products List</data>
<data key="design_theme">Magento Luma</data>
<data key="name" unique="suffix">TestWidget</data>
<data key="sort_order">0</data>
<array key="store_ids">
<item>All Store Views</item>
</array>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<element name="widgetType" type="select" selector="#code"/>
<element name="widgetDesignTheme" type="select" selector="#theme_id"/>
<element name="continue" type="button" timeout="30" selector="#continue_button"/>
<element name="resetBtn" type="button" selector=".page-actions-buttons button#reset" timeout="30"/>
<element name="widgetTitle" type="input" selector="#title"/>
<element name="widgetStoreIds" type="select" selector="#store_ids"/>
<element name="widgetSortOrder" type="input" selector="#sort_order"/>
Expand All @@ -38,14 +39,16 @@
<element name="searchBlock" type="button" selector="//div[@class='admin__filter-actions']/button[@title='Search']"/>
<element name="blockStatus" type="select" selector="//select[@name='chooser_is_active']"/>
<element name="searchedBlock" type="button" selector="//*[@class='magento-message']//tbody/tr/td[1]"/>
<element name="saveWidget" type="select" selector="#save"/>
<element name="saveWidget" type="button" selector="#save" timeout="30"/>
<element name="displayMode" type="select" selector="select[id*='display_mode']"/>
<element name="restrictTypes" type="select" selector="select[id*='types']"/>
<element name="saveAndContinue" type="button" selector="#save_and_edit_button" timeout="30"/>
<element name="widgetInstanceType" type="select" selector=".admin__field-control select#instance_code" />
<!-- Catalog Product List Widget Options -->
<element name="title" type="input" selector="[name='parameters[title]']"/>
<element name="displayPageControl" type="select" selector="[name='parameters[show_pager]']"/>
<element name="numberOfProductsToDisplay" type="input" selector="[name='parameters[products_count]']"/>
<element name="cacheLifetime" type="input" selector="[name='parameters[cache_lifetime]']"/>
</section>
</sections>

65 changes: 65 additions & 0 deletions app/code/Magento/Widget/Test/Mftf/Test/AdminResetWidgetTest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="AdminResetWidgetTest">
<annotations>
<features value="Widget"/>
<stories value="CMS Widgets"/>
<title value="Reset Widget"/>
<description value="Check that admin user can reset widget form after filling out all information"/>
<severity value="MAJOR"/>
<testCaseId value="MC-37892"/>
<group value="widget"/>
</annotations>
<before>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
</before>
<after>
<actionGroup ref="AdminDeleteWidgetActionGroup" stepKey="deleteWidget">
<argument name="widget" value="ProductsListWidget"/>
</actionGroup>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutFromAdmin"/>
</after>
<amOnPage url="{{AdminNewWidgetPage.url}}" stepKey="amOnAdminNewWidgetPage"/>
<actionGroup ref="AdminSetWidgetTypeAndDesignActionGroup" stepKey="firstSetTypeAndDesign">
<argument name="widgetType" value="{{ProductsListWidget.type}}"/>
<argument name="widgetDesign" value="{{ProductsListWidget.design_theme}}"/>
</actionGroup>
<click selector="{{AdminNewWidgetSection.resetBtn}}" stepKey="resetInstance"/>
<dontSeeInField userInput="{{ProductsListWidget.type}}" selector="{{AdminNewWidgetSection.widgetType}}" stepKey="dontSeeTypeAfterReset"/>
<dontSeeInField userInput="{{ProductsListWidget.design_theme}}" selector="{{AdminNewWidgetSection.widgetDesignTheme}}" stepKey="dontSeeDesignAfterReset"/>
<actionGroup ref="AdminSetWidgetTypeAndDesignActionGroup" stepKey="setTypeAndDesignAfterReset">
<argument name="widgetType" value="{{ProductsListWidget.type}}"/>
<argument name="widgetDesign" value="{{ProductsListWidget.design_theme}}"/>
</actionGroup>
<click selector="{{AdminNewWidgetSection.continue}}" stepKey="clickContinue"/>
<actionGroup ref="AdminSetWidgetNameAndStoreActionGroup" stepKey="setNameAndStore">
<argument name="widgetTitle" value="{{ProductsListWidget.name}}"/>
<argument name="widgetStoreIds" value="{{ProductsListWidget.store_ids}}"/>
<argument name="widgetSortOrder" value="{{ProductsListWidget.sort_order}}"/>
</actionGroup>
<click selector="{{AdminNewWidgetSection.resetBtn}}" stepKey="resetNameAndStore"/>
<dontSeeInField userInput="{{ProductsListWidget.name}}" selector="{{AdminNewWidgetSection.widgetTitle}}" stepKey="dontSeeNameAfterReset"/>
<dontSeeInField userInput="{{ProductsListWidget.store_ids[0]}}" selector="{{AdminNewWidgetSection.widgetStoreIds}}" stepKey="dontSeeStoreAfterReset"/>
<dontSeeInField userInput="{{ProductsListWidget.sort_order}}" selector="{{AdminNewWidgetSection.widgetSortOrder}}" stepKey="dontSeeSortOrderAfterReset"/>
<actionGroup ref="AdminSetWidgetNameAndStoreActionGroup" stepKey="setNameAndStoreAfterReset">
<argument name="widgetTitle" value="{{ProductsListWidget.name}}"/>
<argument name="widgetStoreIds" value="{{ProductsListWidget.store_ids}}"/>
<argument name="widgetSortOrder" value="{{ProductsListWidget.sort_order}}"/>
</actionGroup>
<actionGroup ref="AdminSaveAndContinueWidgetActionGroup" stepKey="saveWidgetAndContinue"/>
<click selector="{{AdminNewWidgetSection.resetBtn}}" stepKey="resetWidgetForm"/>
<seeInField userInput="{{ProductsListWidget.name}}" selector="{{AdminNewWidgetSection.widgetTitle}}" stepKey="seeNameAfterReset"/>
<seeInField userInput="{{ProductsListWidget.store_ids[0]}}" selector="{{AdminNewWidgetSection.widgetStoreIds}}" stepKey="seeStoreAfterReset"/>
<seeInField userInput="{{ProductsListWidget.sort_order}}" selector="{{AdminNewWidgetSection.widgetSortOrder}}" stepKey="seeSortOrderAfterReset"/>
<seeInField userInput="{{ProductsListWidget.type}}" selector="{{AdminNewWidgetSection.widgetInstanceType}}" stepKey="seeTypeAfterReset"/>
<seeInField userInput="{{ProductsListWidget.design_theme}}" selector="{{AdminNewWidgetSection.widgetDesignTheme}}" stepKey="seeThemeAfterReset"/>
</test>
</tests>
Loading

0 comments on commit 32ed03c

Please sign in to comment.