Skip to content

Commit

Permalink
ENGCOM-9186: Fix unable to remove parameter override for a webapi route
Browse files Browse the repository at this point in the history
#33844

 - Merge Pull Request #33844 from gowrizrh/magento2:fix/param_override
 - Merged commits:
   1. 2e98f9d
   2. 6a3bdcc
   3. c6aaf4b
   4. ae6a043
   5. 372221b
  • Loading branch information
magento-engcom-team committed Oct 8, 2021
2 parents 90733ec + 372221b commit 3d23c80
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/code/Magento/Webapi/Model/Config/Converter.php
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public function convert($source)
} else {
$serviceClassData[self::KEY_METHODS][$soapMethod][self::KEY_ACL_RESOURCES] =
array_unique(
// phpcs:ignore Magento2.Performance.ForeachArrayMerge
array_merge(
$serviceClassData[self::KEY_METHODS][$soapMethod][self::KEY_ACL_RESOURCES],
$resourcePermissionSet
Expand Down Expand Up @@ -138,7 +139,7 @@ protected function convertMethodParameters($parameters)
}
$name = $parameter->attributes->getNamedItem('name')->nodeValue;
$forceNode = $parameter->attributes->getNamedItem('force');
$force = $forceNode ? (bool)$forceNode->nodeValue : false;
$force = $forceNode ? filter_var($forceNode->nodeValue, FILTER_VALIDATE_BOOLEAN) : false;
$value = $parameter->nodeValue;
$data[$name] = [
self::KEY_FORCE => $force,
Expand Down

0 comments on commit 3d23c80

Please sign in to comment.