#19230: Static test fix.

magento · Jan 24, 2019 · 44760ff · 44760ff
1 parent 5a24c41
commit 44760ff
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/app/code/Magento/Sales/Model/Order/CustomerAssignment.php b/app/code/Magento/Sales/Model/Order/CustomerAssignment.php
@@ -12,6 +12,9 @@
 use Magento\Customer\Api\Data\CustomerInterface;
 use Magento\Framework\Event\ManagerInterface;
 
+/**
+ * Assign customer to order.
+ */
 class CustomerAssignment
 {
     /**
@@ -39,6 +42,8 @@ public function __construct(
     }
 
     /**
+     * Assign customer to order.
+     *
      * @param OrderInterface $order
      * @param CustomerInterface $customer
      */

diff --git a/app/code/Magento/Sales/Observer/AssignOrderToCustomerObserver.php b/app/code/Magento/Sales/Observer/AssignOrderToCustomerObserver.php
@@ -43,7 +43,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function execute(Observer $observer)
     {

diff --git a/app/code/Magento/SalesRule/Observer/AssignCouponDataAfterOrderCustomerAssignObserver.php b/app/code/Magento/SalesRule/Observer/AssignCouponDataAfterOrderCustomerAssignObserver.php
@@ -14,6 +14,9 @@
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Framework\Event\ObserverInterface;
 
+/**
+ * Assign coupon data after order customer assign.
+ */
 class AssignCouponDataAfterOrderCustomerAssignObserver implements ObserverInterface
 {
     const EVENT_KEY_CUSTOMER = 'customer';

diff --git a/...stsuite/Magento/SalesRule/Model/Observer/AssignCouponDataAfterOrderCustomerAssignTest.php b/...stsuite/Magento/SalesRule/Model/Observer/AssignCouponDataAfterOrderCustomerAssignTest.php
@@ -6,6 +6,7 @@
 
 namespace Magento\SalesRule\Model\Observer;
 
+use Magento\Framework\Controller\Result\Redirect;
 use Magento\Sales\Model\Order;
 use Magento\Customer\Model\GroupManagement;
 use Magento\SalesRule\Api\CouponRepositoryInterface;
@@ -251,8 +252,9 @@ private function makeOrderWithCouponAsGuest(Coupon $coupon) : Order
 
     /**
      * @param Order $order
+     * @return Redirect
      */
-    private function delegateOrderToBeAssigned(Order $order)
+    private function delegateOrderToBeAssigned(Order $order): Redirect
     {
         $this->delegateCustomerService->delegateNew($order->getId());
     }