Skip to content

Commit

Permalink
Replace all forEach Array functions with for...of in the dom-obse…
Browse files Browse the repository at this point in the history
…rver.js to improve the page load performance for product edit pages.
  • Loading branch information
Dennis Schmitz committed May 9, 2023
1 parent 1b6dc48 commit 5b931fe
Showing 1 changed file with 18 additions and 16 deletions.
34 changes: 18 additions & 16 deletions app/code/Magento/Ui/view/base/web/js/lib/view/utils/dom-observer.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ define([
*/
function processAdded(node) {
_.each(watchers.selectors, function (listeners, selector) {
listeners.forEach(function (data) {
for (var data of listeners) {
if (!data.ctx.contains(node) || !$(node, data.ctx).is(selector)) {
return;
}
Expand All @@ -157,7 +157,7 @@ define([
} else if (data.type === 'remove') {
addRemovalListener(node, data);
}
});
}
});
}

Expand All @@ -174,10 +174,9 @@ define([
return;
}

listeners.forEach(function (data) {
for (var data of listeners) {
trigger(node, data);
});

}
removeNodeData(node);
}

Expand All @@ -194,12 +193,12 @@ define([

nodes = _.toArray(nodes).filter(isElementNode);

nodes.forEach(function (node) {
for (var node of nodes) {
result.push(node);

children = extractChildren(node);
result = result.concat(children);
});
}

return result;
}
Expand All @@ -216,10 +215,10 @@ define([
var removed = [],
added = [];

mutations.forEach(function (record) {
for (var record of mutations) {
removed = removed.concat(_.toArray(record.removedNodes));
added = added.concat(_.toArray(record.addedNodes));
});
}

removed = removed.filter(function (node) {
var addIndex = added.indexOf(node),
Expand Down Expand Up @@ -287,8 +286,12 @@ define([
if (shouldObserveMutations(mutations)) {
changes = formChangesLists(mutations);

changes.removed.forEach(processRemoved);
changes.added.forEach(processAdded);
for (var node of changes.removed) {
processRemoved(node);
}
for (var node of changes.added) {
processAdded(node);
}
}
});

Expand Down Expand Up @@ -331,10 +334,9 @@ define([

nodes = $(selector, data.ctx).toArray();

nodes.forEach(function (node) {
for (var node of nodes) {
trigger(node, data);
});

}
addSelectorListener(selector, data);
},

Expand Down Expand Up @@ -366,9 +368,9 @@ define([
addSelectorListener(selector, data);
}

nodes.forEach(function (node) {
for (var node of nodes) {
addRemovalListener(node, data);
});
}
},

/**
Expand Down

0 comments on commit 5b931fe

Please sign in to comment.