Skip to content

Commit

Permalink
Merge branch '2.4-develop' into issue/26384
Browse files Browse the repository at this point in the history
# Conflicts:
#	app/code/Magento/Store/Test/Unit/Controller/Store/RedirectTest.php
  • Loading branch information
engcom-Charlie committed Feb 11, 2020
2 parents 9cad4dc + 90ea3f1 commit 6024195
Show file tree
Hide file tree
Showing 451 changed files with 15,247 additions and 3,541 deletions.
3 changes: 1 addition & 2 deletions app/code/Magento/AdvancedPricingImportExport/etc/module.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_AdvancedPricingImportExport" >
</module>
<module name="Magento_AdvancedPricingImportExport"/>
</config>
2 changes: 1 addition & 1 deletion app/code/Magento/Analytics/Model/Connector.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function __construct(
public function execute($commandName)
{
if (!array_key_exists($commandName, $this->commands)) {
throw new NotFoundException(__('Command was not found.'));
throw new NotFoundException(__('Command "%1" was not found.', $commandName));
}

/** @var \Magento\Analytics\Model\Connector\CommandInterface $command */
Expand Down
6 changes: 5 additions & 1 deletion app/code/Magento/Analytics/Test/Unit/Model/ConnectorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,13 @@ public function testExecute()
}

/**
* Executing non-existing command
*
* @expectedException \Magento\Framework\Exception\NotFoundException
* @expectedExceptionMessage Command "register" was not found.
* @return void
*/
public function testExecuteCommandNotFound()
public function testExecuteCommandNotFound(): void
{
$commandName = 'register';
$this->connector->execute($commandName);
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Analytics/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"There was an error save new configuration value.","There was an error save new configuration value."
"Please select an industry.","Please select an industry."
"--Please Select--","--Please Select--"
"Command was not found.","Command was not found."
"Command "%1" was not found.","Command "%1" was not found."
"Input data must be string or convertible into string.","Input data must be string or convertible into string."
"Input data must be non-empty string.","Input data must be non-empty string."
"Not valid cipher method.","Not valid cipher method."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ define(
'Magento_Vault/js/view/payment/vault-enabler',
'Magento_Braintree/js/view/payment/kount',
'mage/translate',
'prototype',
'domReady!'
],
function (
Expand Down
13 changes: 11 additions & 2 deletions app/code/Magento/Bundle/Observer/AppendUpsellProductsObserver.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

use Magento\Framework\Event\ObserverInterface;

/**
* Class adds bundle products into up-sell products collection
*/
class AppendUpsellProductsObserver implements ObserverInterface
{
/**
Expand Down Expand Up @@ -98,9 +101,15 @@ public function execute(\Magento\Framework\Event\Observer $observer)
}

/* @var $bundleCollection \Magento\Catalog\Model\ResourceModel\Product\Collection */
$bundleCollection = $product->getCollection()->addAttributeToSelect(
$bundleCollection = $product->getCollection();
$bundleCollection->addAttributeToSelect(
$this->config->getProductAttributes()
)->addStoreFilter()->addMinimalPrice()->addFinalPrice()->addTaxPercents()->setVisibility(
);
$bundleCollection->addStoreFilter();
$bundleCollection->addMinimalPrice();
$bundleCollection->addFinalPrice();
$bundleCollection->addTaxPercents();
$bundleCollection->setVisibility(
$this->productVisibility->getVisibleInCatalogIds()
);

Expand Down
11 changes: 8 additions & 3 deletions app/code/Magento/Bundle/Observer/InitOptionRendererObserver.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,25 @@
*/
namespace Magento\Bundle\Observer;

use Magento\Bundle\Helper\Catalog\Product\Configuration;
use Magento\Framework\Event\Observer;
use Magento\Framework\Event\ObserverInterface;

/**
* Initiates render options
*/
class InitOptionRendererObserver implements ObserverInterface
{
/**
* Initialize product options renderer with bundle specific params
*
* @param \Magento\Framework\Event\Observer $observer
* @param Observer $observer
* @return $this
*/
public function execute(\Magento\Framework\Event\Observer $observer)
public function execute(Observer $observer)
{
$block = $observer->getBlock();
$block->addOptionsRenderCfg('bundle', \Magento\Bundle\Helper\Catalog\Product\Configuration::class);
$block->addOptionsRenderCfg('bundle', Configuration::class);
return $this;
}
}
Loading

0 comments on commit 6024195

Please sign in to comment.