Skip to content

Commit

Permalink
ENGCOM-7491: Deprecate AbstractAction and it's public methods #27964
Browse files Browse the repository at this point in the history
 - Merge Pull Request #27964 from lbajsarowicz/magento2:bugfix/deprecate-action
 - Merged commits:
   1. 1759898
   2. 075d377
   3. f5a013e
   4. 90b3785
   5. d857b89
  • Loading branch information
magento-engcom-team committed Apr 27, 2020
2 parents f442fa9 + d857b89 commit a021cff
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 6 additions & 2 deletions lib/internal/Magento/Framework/App/Action/AbstractAction.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<?php
/**
* Abstract redirect/forward action class
*
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
Expand All @@ -10,6 +8,12 @@
use Magento\Framework\App\RequestInterface;
use Magento\Framework\App\ResponseInterface;

/**
* Abstract redirect/forward action class
*
* @deprecated Inheritance in controllers should be avoided in favor of composition
* @see \Magento\Framework\App\ActionInterface
*/
abstract class AbstractAction implements \Magento\Framework\App\ActionInterface
{
/**
Expand Down
3 changes: 2 additions & 1 deletion lib/internal/Magento/Framework/App/Action/Action.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
* It contains standard action behavior (event dispatching, flag checks)
* Action classes that do not extend from this class will lose this behavior and might not function correctly
*
* @deprecated Use \Magento\Framework\App\ActionInterface
* @deprecated Inheritance in controllers should be avoided in favor of composition
* @see \Magento\Framework\App\ActionInterface
*
* phpcs:disable Magento2.Classes.AbstractApi
* @api
Expand Down

0 comments on commit a021cff

Please sign in to comment.