Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant put id or data attribute on <img> tags in the M2 wysiwyg. #10353

Open
iokbomkamp opened this issue Jul 27, 2017 · 12 comments
Open

Cant put id or data attribute on <img> tags in the M2 wysiwyg. #10353

iokbomkamp opened this issue Jul 27, 2017 · 12 comments
Assignees
@engcom-Delta
Labels
Area: Framework bug report CD Issue recommended for the contribution day Component: Framework/Wysiwyg Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
High Priority Backlog

Comments

@iokbomkamp
Copy link

iokbomkamp commented Jul 27, 2017 •
edited by engcom-Echo

After adding an id to tags in the wysiwyg, it errors:

Preconditions

  1. Magento 2.4

Steps to reproduce

  1. Go to content, edit a page, insert an image in the wysiwyg. Save it. Then add an id attribute to the image like

<img id="image-id" src="help.jpg" />

or

<img data-id="img-id" src="help.jpg" />. It will throw an error:
selection_367

Then the code gets weird and weird strings get added to the src:
selection_366

Expected result

  1. It shouldn't throw an error.

Actual result

  1. The error message:
    selection_367

After error what code looks like (images won't work like this either):
selection_366
@iokbomkamp iokbomkamp changed the title Cant put id or data attribute on <img> tags in the M2 wyswig. Cant put id or data attribute on <img> tags in the M2 wysiwyg. Jul 27, 2017
@magento-engcom-team magento-engcom-team added G1 Passed bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 20, 2017
@magento-engcom-team
Copy link
Contributor

@iokbomkamp, thank you for your report.
We've created internal ticket(s) MAGETWO-75586 to track progress on the issue.

@osrecio osrecio mentioned this issue Sep 25, 2017
Closed
4 tasks
@PieterCappelle PieterCappelle mentioned this issue Sep 26, 2017
Closed
4 tasks
@PieterCappelle
Copy link
Contributor

Should be fixed in #11053 .

@benathomeofchampions benathomeofchampions self-assigned this Jun 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2019

Hi @benathomeofchampions. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

benathomeofchampions added a commit to benathomeofchampions/magento2 that referenced this issue Jun 18, 2019
@benathomeofchampions
magento#10353 : Cant put id or data attribute on <img> tags in the M2…
61035ef 
… wysiwyg.

Fixes issue whereby an ID attribute is added to an <img> via the WYSIWYG, and a proceeded base64 decode of the ID causes an exception.

This introduces a new method Base64.isBase64() and performs a check before trying to get an widget code from the ID.
Closed
4 tasks
@sdzhepa sdzhepa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 23, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 6, 2020
@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@DipaliBhalala
Copy link

@magento I am working on it

@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2020

Hi @DipaliBhalala! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@DipaliBhalala
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2020

Hi @DipaliBhalala! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@DipaliBhalala
Copy link

@magento I am working on it

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Oct 10, 2020
@DipaliBhalala
Copy link

I've tried this in Magento 2.4,
checked id and data-id ...both are working fine
It's not throwing any kind of error!

@sidolov sidolov added this to Dev In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Dev in Community Backlog Oct 20, 2020
@ghost ghost removed this from Dev In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost unassigned DipaliBhalala Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Nov 4, 2020
@engcom-Delta engcom-Delta self-assigned this May 28, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented May 28, 2024

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Delta engcom-Delta

Labels
Area: Framework bug report CD Issue recommended for the contribution day Component: Framework/Wysiwyg Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
High Priority Backlog
  
Dev In Progress
Milestone
No milestone
Development

No branches or pull requests