i18n:collect-phrases -m can't find many important magento phrases

[scholtz]

Summary
This is continuation of thread #2630
Magento 2.2 clear installation using script http://apps.scholtz.sk/magento.install.script.txt

Preconditions

1. Magento 2.4-develop
2. PHP 7.1, Nginx, Mysql 5.7

Steps to reproduce

1. Install Magento and download SK language pack
2. do collect phrases php bin/magento i18n:collect-phrases -o "$VER.csv" -m
3. translate phrases
4. Check translations in admin

(I have full translation of magento to slovak language, so i skip step 2 i install it through the script listed above)

Expected result

I expect all texts to be localised

Actual result

Some phrases are not translated.. Btw, i can see some progress in the 2 years work now, but still some are missing..

[magento-engcom-team]

@scholtz, thank you for your report.
We've created internal ticket(s) MAGETWO-80604 to track progress on the issue.

[PascalBrouwers]

Added a PR for 2.2-develop.

[PascalBrouwers]

Added a PR for 2.3-develop while we're at it.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[Bartlomiejsz]

@magento I am working on this

[magento-engcom-team]

Hi @scholtz. Thank you for your report.
The issue has been fixed in #30320 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

• 48216f3e13d04b8755b70f8b9b1399d87a33ab91

The fix will be available with the upcoming 2.4.2 release.

[maksymz]

Hi, @scholtz and @magento-engcom-team !

According to the official Magento 2 documentations, there is a way to translate HTML attributes, but this is not covered as well. Here is a text from the documentation:

When a string is added as an attribute of an HTML element:

<input type="text" data-bind="attr: {placeholder: $t('First Name')}" />

https://devdocs.magento.com/guides/v2.4/frontend-dev-guide/translations/translate_theory.html

This was of translating attributes does not seem to be used in the Magento 2 itself (if my search is correct). Though, it is officially documented, is used by some vendors and it can be found in some Q&A on the Internet ( like here - https://magento.stackexchange.com/questions/181070/magento-2-translate-input-placeholder-attribute-string-in-knockout-html-templat )

As a result, this is still a potential issue I think...

Regards,
Max

[maksymz]

Possible additional regular expression for the class \Magento\Setup\Module\I18n\Parser\Adapter\Html is:

'/\\$t\(\s*([\'"])(?<value>.*?[^\\\])\1.*?[),]/i'

This is the same as in \Magento\Setup\Module\I18n\Parser\Adapter\Js with ?<value> to catch the text itself for further processing

[hostep]

Hi @maksymz, feel free to open a pull request with your suggest fix. If that's not possible somehow, I'd recommend you to open a new issue instead of commenting on an old closed one which is considered fixed. Thanks! 🙂

[gabrieldagama]

Hi @scholtz. Thank you for your report.
The issue has been fixed in #31804 by @maksymz in 2.4-develop branch
Related commit(s):

• 754ea5fcb1ed51281019235b7095d8152a6ffdc6
• 77daafd4571efbaf93b302076017ea3efd757e91
• f847294d47d95ee171a2b6ea860be68ebeb7aff5

The fix will be available with the upcoming 2.4.3 release.