-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n:collect-phrases -m can't find many important magento phrases #11175
Comments
@scholtz, thank you for your report. |
Added a PR for 2.2-develop. |
Added a PR for 2.3-develop while we're at it. |
Hi @engcom-Charlie. Thank you for working on this issue.
|
@magento I am working on this |
… magento phrases
Hi @scholtz. Thank you for your report. The fix will be available with the upcoming 2.4.2 release. |
…ortant magento phrases #30320
Hi, @scholtz and @magento-engcom-team ! According to the official Magento 2 documentations, there is a way to translate HTML attributes, but this is not covered as well. Here is a text from the documentation:
<input type="text" data-bind="attr: {placeholder: $t('First Name')}" /> https://devdocs.magento.com/guides/v2.4/frontend-dev-guide/translations/translate_theory.html This was of translating attributes does not seem to be used in the Magento 2 itself (if my search is correct). Though, it is officially documented, is used by some vendors and it can be found in some Q&A on the Internet ( like here - https://magento.stackexchange.com/questions/181070/magento-2-translate-input-placeholder-attribute-string-in-knockout-html-templat ) As a result, this is still a potential issue I think... Regards, |
Possible additional regular expression for the class '/\\$t\(\s*([\'"])(?<value>.*?[^\\\])\1.*?[),]/i' This is the same as in |
Hi @maksymz, feel free to open a pull request with your suggest fix. If that's not possible somehow, I'd recommend you to open a new issue instead of commenting on an old closed one which is considered fixed. Thanks! 🙂 |
… magento phrases - added parsing of the attr translations via `$t('Text')`
… magento phrases - made patterns case-sensitive because translations does not work with uppercase bindings/tags/function names
… magento phrases - moved patterns to constants, updated JS parser test
Hi @scholtz. Thank you for your report.
The fix will be available with the upcoming 2.4.3 release. |
…ortant Magento phrases - added parsing of the attr translations via `$t('Text')` #31804
Summary
This is continuation of thread #2630
Magento 2.2 clear installation using script http://apps.scholtz.sk/magento.install.script.txt
Preconditions
Steps to reproduce
(I have full translation of magento to slovak language, so i skip step 2 i install it through the script listed above)
Expected result
I expect all texts to be localised
Actual result
Some phrases are not translated.. Btw, i can see some progress in the 2 years work now, but still some are missing..
The text was updated successfully, but these errors were encountered: