"Ignore this notification" isn't working

[sigismund]

Preconditions

1. Magento 2.2
2. 3 store views

Steps to reproduce

1. Set-up wrong tax settings
2. Message similar "To apply the discount on prices including tax and ..." will be display as system message.
3. Click on "ignore this notification"

Expected result

1. System message (ignoreTaxNotification) shouldn't be displayed in future because it's supposed to be ignored

Actual result

1. Message is displayed regardless of being on ignore list.

Probably unrelated

This is most likely unrelated, but even after changing values to "correct" mode all checks in function checkSettings in ApplyDiscountOnPrices are still returning false even though they are all set to true.

Checks I mentioned:

$this->taxConfig->priceIncludesTax($store)
!$this->taxConfig->applyTaxAfterDiscount($store)
!$this->taxConfig->discountTax($store);

[magento-engcom-team]

@sigismund, thank you for your report.
We've created internal ticket(s) MAGETWO-81606 to track progress on the issue.

[magento-team]

Internal ticket to track issue progress: MAGETWO-82753

[okorshenko]

The issue has been fixed and delivered to 2.2-develop branch. Will be available with 2.2.2 release

[magento-engcom-team]

Hi @sigismund. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1285 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• ad6c0af
• 6d3d70a
• 6b0c02c
• c8abb13
• c6a9b5f
• c867b81
• 88a3ad0
• d87e316
• c76b04c
• 5ae2109
• 931133a
• 4c927a0
• 060a8f9
• 4da2a7d
• 008ef55
• d3642e8
• d37ce08
• b22b232
• 6c02a2d
• f2ec2ea

The fix will be available with the upcoming patch release.