Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Item price cannot differ per website #12584

Closed
AntonEvers opened this issue Dec 7, 2017 · 12 comments · Fixed by #27315
Closed

Bundle Item price cannot differ per website #12584

AntonEvers opened this issue Dec 7, 2017 · 12 comments · Fixed by #27315
Assignees
@rain2o
Labels
Component: Bundle Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Progress: PR in progress Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@AntonEvers
Copy link
Contributor

Preconditions

  1. Magento 2.2-develop
  2. Magento 2.1-develop

Steps to reproduce

  1. Set Stores | Configuration | Catalog | Catalog | Price | Catalog Price Scope to 'Website'
  2. Create a second website, store and store view
  3. Create a bundle product with option 'Dynamic Price': 'No'
  4. Add it to both websites
  5. Add a bundle item with price type 'fixed' and price '12'
  6. Save the product
  7. Use the dropdown on the top left to change scope to your second store view
  8. Set the Bundle Item price to '10'
  9. Save the product

Expected result

  1. The bundle item should have price '12' in the default scope and in the first store view
  2. The bundle item should have price '10' in the second store view
  3. Website specific prices should be saved in table catalog_product_bundle_selection_price

Actual result

  1. The bundle item has price '10' everywhere
  2. There are no entries in catalog_product_bundle_selection_price
  3. The price is only saved in catalog_product_bundle_selection which is not website specific

Tip: almost all logic is already in place, because if you add entries to the catalog_product_bundle_selection_price table manually, the bundle items do have different prices per website, until you save the product in the backend. Then the catalog_product_bundle_selection_price entry is deleted again and only the catalog_product_bundle_selection entry remains.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 7, 2017
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Dec 7, 2017
Fixes magento#12584
f8f6ed4 
Website id is checked for but is not added to bundle option prices
@AntonEvers AntonEvers mentioned this issue Dec 7, 2017
Closed
4 tasks
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 8, 2017
@magento-engcom-team
Copy link
Contributor

@ajpevers, thank you for your report.
We've created internal ticket(s) MAGETWO-85221 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 8, 2017
@TomWhitmey1
Copy link

@magento-engcom-team Do you guys have a timeframe on when this fix might go live? I can see in your backlog it is sitting in 'to-do'. Grateful for advice here.

@nkajic
Copy link
Member

nkajic commented Mar 14, 2018 •
edited
Loading

Hi @ajpevers,

I am testing this patch on my staging with M2.2.0. and M2.2.3 After applying patch I have noticed when saving product on store level it applies this price to website level (that is fine), but it also applies same price to default level resulting in replacing original default price and replacing prices for other websites which does not have their price in catalog_product_bundle_selection_price

In addition to your patch we should somehow stop magento updating price in catalog_product_bundle_selection if product have been updated on store/website level.

I will try to find myself where this magic happens, if you can help please let me know. Thx.

@PerfectusInc
Copy link

PerfectusInc commented Nov 16, 2018 •
edited
Loading

Any update on this issue? I can still see this issue on latest Magento v2.2.6
When this will be resolved?

Thanks

@emastyle
Copy link

Same issue seems still present on Magento 2.3.

@JPinkstonSaatva
Copy link

Any update on this issue? This is a blocker for the ability to set a different price per currency for bundle items.

@engcom-Bravo engcom-Bravo self-assigned this Jan 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Bundle Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 9, 2020
@ghost ghost unassigned engcom-Bravo Jan 9, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Sep 16, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 16, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@sidolov sidolov added this to Pull Request In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from PR In Progress in Community Backlog Oct 20, 2020
@ghost ghost removed this from Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Nov 19, 2020
@engcom-Foxtrot
magento#12584: Bundle Item price cannot differ per website.
a7adbdc
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Nov 19, 2020
@engcom-Foxtrot
magento#12584: Bundle Item price cannot differ per website.
ac37ae1
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Nov 19, 2020
@engcom-Foxtrot
magento#12584: Bundle Item price cannot differ per website.
b6be049
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Nov 19, 2020
@engcom-Foxtrot
magento#12584: Bundle Item price cannot differ per website.
975c0c1
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Jan 14, 2021
@engcom-Foxtrot
magento#12584 Bundle Item price cannot differ per website - integrati…
ec8a7c9 
…on tests fix.
engcom-Foxtrot added a commit to rain2o/magento2 that referenced this issue Jan 15, 2021
@engcom-Foxtrot
magento#12584 Bundle Item price cannot differ per website - integrati…
88ea963 
…on tests fix.
@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 18, 2021
@gabrieldagama
Copy link
Contributor

Hi @AntonEvers. Thank you for your report.
The issue has been fixed in #27315 by @rain2o in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Feb 18, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Feb 18, 2021
magento-engcom-team added a commit that referenced this issue Feb 18, 2021
@magento-engcom-team
ENGCOM-7141: Fixes #12584 Bundle Item price cannot differ per website #…
15015fa 
…27315

 - Merge Pull Request #27315 from rain2o/magento2:bugfix/issue-12584
 - Merged commits:
   1. b25a34f
   2. fc9559e
   3. a59b0e8
   4. 8cca552
   5. 49c261e
   6. 659beb2
   7. f75a78b
   8. fd40a7b
   9. d7f283c
   10. 56ef44b
   11. b5c9757
   12. 9f622ee
   13. 64db19a
   14. dc7cc2c
   15. ed0f987
   16. ac37ae1
   17. 975c0c1
   18. 171c54d
   19. a2a9cba
   20. ea54519
   21. 377e070
   22. 605fb88
   23. 6cc13cc
   24. 88ea963
   25. dc3226b
   26. 7da12c1
   27. c57d4d0
   28. f6bb216
   29. 27627ca
   30. b00b423
   31. eb5e30c
magento-engcom-team pushed a commit that referenced this issue Feb 18, 2021
@gabrieldagama
ENGCOM-7141: Fixes #12584 Bundle Item price cannot differ per website #…
a44cbab 
…27315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rain2o rain2o

Labels
Component: Bundle Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Progress: PR in progress Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #12584 Bundle Item price cannot differ per website rain2o/magento2