Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeIdType doesn't allow numbers #1290

Closed
mzeis opened this issue May 19, 2015 · 4 comments
Closed

routeIdType doesn't allow numbers #1290

mzeis opened this issue May 19, 2015 · 4 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@mzeis
Copy link
Contributor

mzeis commented May 19, 2015

When defining a route in etc/frontend/routes.xml:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../lib/internal/Magento/Framework/App/etc/routes.xsd">
    <router id="standard">
        <route id="mzeis_test123" frontName="test123">
            <module name="Mzeis_Test123" />
        </route>
    </router>
</config>

The XSD doesn't allow to use numbers in the id attribute of the route node, see routes.xsd and routes_merged.xsd.

Is there a reason for doing that? Given that numbers are valid in the module names as well as routerIdType and I expect developers to use the name of the module for the route id in many cases I'd suggest to allow numbers (or better: the same pattern as for the module name).

@anupdugar anupdugar added the PS label May 20, 2015
@anupdugar
Copy link
Contributor

Thanks for reporting the issue @mzeis.
Yes, it makes sense to allow numbers for route id attribute. I have created an issue to track this : MAGETWO-37855

@anupdugar anupdugar added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels May 21, 2015
@cmuench
Copy link
Contributor

cmuench commented May 29, 2015

👍 We need numbers to. Our prefix starts with "n98".

@vpelipenko
Copy link
Contributor

@mzeis, internal ticket is closed and resolved, so fix is on public github. Are you OK with provided changes?

@mzeis
Copy link
Contributor Author

mzeis commented Jul 7, 2015

Didn't test but the code change looks good, thanks.

@mzeis mzeis closed this as completed Jul 7, 2015
magento-team pushed a commit that referenced this issue Jul 6, 2017
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
…ngular-names-on-plural-in-web-api

Singular names switched to plural in webapi calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests

4 participants