Invoice Sales Email not send

[LordHansolo]

Preconditions

1. Magento 2.2.2
2. OS: Ubuntu 16.04
3. Mysql version 5.7.21
4. PHP version 7.0.22

Steps to reproduce

1. Set up "Stores -> Settings -> Configuration -> Sales -> Sales Emails -> Invoice -> Enabled -> Yes"
2. Configure PayPal "Stores -> Settings -> Configuration -> Sales -> Payment Methods -> PayPal -> Payment Action -> Sale"
3. Make order and pay with PayPal.

Expected result

1. Order Created
2. Email with order information send.
3. Invoice Created
4. Email with invoice information send

Actual result

1. Order Created <- ok
2. Email with order information send. <- ok
3. Invoice Created <- ok
4. Email with invoice information is not send <- wrong

Overview docs http://docs.magento.com/m2/ce/user_guide/configuration/sales/sales-emails.html
Since sales emails for invoice is enabled Magento should sends a transactional email for each invoice generated.

[sivajik34]

@LordHansolo Asynchronous sending enabled? then it should run through cron.
You can refer https://magento.stackexchange.com/questions/198779/how-does-asynchronous-email-sending-works-in-magento-2

[LordHansolo]

@sivajik34 Thank you for response.
Now I understand that config is only for "Asynchronous sending".
I expected that email with invoice is send always after invoice is generated regardless "Asynchronous sending" configuration.
I expected that especially when you pay via PayPal with "Payment Action" set on "Sale". Invoice is generated automatically with status Paid if everything is correct but email is not send.

[sivajik34]

if Asynchronous sending disabled:
then flow
step1:
magento/module-sales/etc/events.xml:
<observer name="sales_send_order_invoice_emails" instance="SalesOrderInvoiceSendEmailsObserver" />
step2:
magento/module-sales/etc/di.xml:

 <virtualType name="SalesOrderInvoiceSendEmailsObserver" type="Magento\Sales\Observer\Virtual\SendEmails">
        <arguments>
            <argument name="emailSenderHandler" xsi:type="object">SalesOrderInvoiceSendEmails</argument>
        </arguments>
    </virtualType>

 <virtualType name="SalesOrderInvoiceSendEmails" type="Magento\Sales\Model\EmailSenderHandler">
        <arguments>
            <argument name="emailSender" xsi:type="object">Magento\Sales\Model\Order\Email\Sender\InvoiceSender</argument>
            <argument name="entityResource" xsi:type="object">Magento\Sales\Model\ResourceModel\Order\Invoice</argument>
            <argument name="entityCollection" xsi:type="object" shared="false">Magento\Sales\Model\ResourceModel\Order\Invoice\Collection</argument>
        </arguments>
    </virtualType>

step 3:
Magento\Sales\Observer\Virtual\SendEmails:

 /**
     * Handles asynchronous email sending during corresponding
     * cron job.
     *
     * Also method is used in the next events:
     *
     * - config_data_sales_email_general_async_sending_disabled
     *
     * Works only if asynchronous email sending is enabled
     * in global settings.
     *
     * @param \Magento\Framework\Event\Observer $observer
     * @return void
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public function execute(\Magento\Framework\Event\Observer $observer)
    {
        $this->emailSenderHandler->sendEmails();
    }

here emailSenderHandler -> Magento\Sales\Model\EmailSenderHandler

/**
    * Handles asynchronous email sending
    * @return void
    */
   public function sendEmails()
   {
       if ($this->globalConfig->getValue('sales_email/general/async_sending')) {
           $this->entityCollection->addFieldToFilter('send_email', ['eq' => 1]);
           $this->entityCollection->addFieldToFilter('email_sent', ['null' => true]);

           /** @var \Magento\Sales\Model\AbstractModel $item */
           foreach ($this->entityCollection->getItems() as $item) {
               if ($this->emailSender->send($item, true)) {
                   $this->entityResource->save(
                       $item->setEmailSent(true)
                   );
               }
           }
       }
   }

even if you disable async finally its calling async code. still, i have some confusion implementation of this.

[LordHansolo]

@sivajik34 One more time thank you.
I updated my previous comment.
Now it is clear, that invoice email is not send if "Asynchronous sending" is disabled.
During read configuration files, especially magento/module-sales/etc/events.xml with fragment below:
<event name="config_data_sales_email_general_async_sending_disabled"> ... </event>
I had hape that emails should be send but after fully code read my hope has gone out ;)

[LucScu]

some progress on this issue?

Hi @LordHansolo thank you for your report.
We've acknowledged the issue and added to our backlog.