Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Report Bugs link not open in new tab? #14010

Closed
webshouters opened this issue Mar 8, 2018 · 7 comments
Closed

Why Report Bugs link not open in new tab? #14010

webshouters opened this issue Mar 8, 2018 · 7 comments
Labels
feature request Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed non-issue

Comments

@webshouters
Copy link

webshouters commented Mar 8, 2018

Why Report Bugs link not open in new tab?

It should be open in new tab(target="_blank").

new-tab-link

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Mar 8, 2018
@daniloargentiero daniloargentiero self-assigned this Mar 8, 2018
@orlangur
Copy link
Contributor

orlangur commented Mar 8, 2018

It should be open in new tab(target="_blank").

No.

It is generally considered a good practice to let user decide whether a link should be opened in a new tab. So, pressing Ctrl+Click link is opened in new tab, pressing Shift+Click link is opened in new window and user is not forced to open a new tab or window.

@daniloargentiero
Copy link

Hi @orlangur,
This is useful because in this way you don't loose your currently opened admin page.

@orlangur
Copy link
Contributor

orlangur commented Mar 9, 2018

@DaniloEmpire there is a Back button in browser to not lose an opened admin page.

Default behavior is opening the link in the same tab so such behavior is quite expectable for user.

@daniloargentiero
Copy link

daniloargentiero commented Mar 9, 2018

@orlangur "Back button" in browser don't always keeps form's data.

A scenario for example:

  1. Create a new product
  2. Compile the form (it takes at least 5/10 minutes)
  3. Click on "Report an Issue" (because you encounter an issue in that specific scenario)
  4. Click on browser's "Back button"
  5. Result: an empty form. You have to refill form to replicate the scenario. This is boring and can leads developers to abandon the idea to send an issue.

In this case, Default behavior is not a good choice.

@orlangur
Copy link
Contributor

orlangur commented Mar 9, 2018

Click on "Report an Issue"

User is aware that to open issue in new tab or window you need to press Ctrl/Shift + Click.

Click on browser's "Back button"

In most cases you will see nonempty form (some data could be missed in tabs loaded via AJAX). Also, some modern browsers ask if user really wants to leave page as form data entered may be lost. A generic cross-browser mechanism could be implemented on Magento side to avoid data loss (show confirmation dialog when there is some unsaved form data).

Placing target=blank in random places is not a right way to improve user experience in 2k18.

@magento-engcom-team
Copy link
Contributor

Hi @webshouters. Thank you for your report.
The issue has been fixed in #14016 by @DaniloEmpire in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @webshouters. Thank you for your report.
The issue has been fixed in #14121 by @sidolov in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed non-issue
Projects
None yet
Development

No branches or pull requests

4 participants