Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. #14294

Closed
bobemoe opened this issue Mar 23, 2018 · 2 comments
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@bobemoe
Copy link
Contributor

bobemoe commented Mar 23, 2018

Preconditions

PHP 7.0.27-1-dotdeb+8.1 (cli) ( NTS )
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.0.27-1-dotdeb+8.1, Copyright (c) 1999-2017, by Zend Technologies

nginx version: nginx/1.12.2

Linux 3.16.0-5-amd64 #1 SMP Debian 3.16.51-3+deb8u1 (2018-01-08) x86_64 GNU/Linux

mysql Ver 15.1 Distrib 10.0.32-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

Steps to reproduce

  1. Clean install of magento2.1.12 using composer.
  2. Admin->Stores->Add Store View (name: test, code: test, enabled)
  3. Fontend use store switcher to change store view to 'test' store. Notice that ?___store=test is added to the URL.
  4. Navigate to another page (e.g. terms)
  5. Click 'Back' in the browser

Expected result

The previous page is displayed

Actual result

Firefox complains "Expired Document"

Notes

I've tested this with the different version of magento. It seems that before 2.1.11 the ?___store= was not added to the URL and switching was handled, i guess, purely by POST/session/cookie.
Since 2.1.11 the ?___store= is added upon switching and going back to any page that has that in the URL causes this issue.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 23, 2018
@bobemoe bobemoe changed the title Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. Mar 24, 2018
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Mar 26, 2018
@magento-engcom-team
Copy link
Contributor

@bobemoe , thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team
Copy link
Contributor

Hi @bobemoe. Thank you for your report.
The issue has been fixed in #15961 by @Mobecls in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants