14294 switching store breaks back functionality #15525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds getStoreUrl() method to app/code/Magento/Store/Block/Switcher.php Modifies switcher-option's links in Magento/Store/view/frontend/templates/switch/stores.phtml and languages.phtml templates
Fixes 'Potentially XSS vulnerability. Please verify that output is escaped'.
okorshenko
suggested changes
May 25, 2018
| * @param Store $store | ||
| * @return string | ||
| */ | ||
| public function getStoreUrl(Store $store) |
There was a problem hiding this comment.
hi @Mobecls
Thank you for the pull requests.
Unfortunately this is prohibited code change that needs to be refactored https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/index.html#prohibited-code-changes
There was a problem hiding this comment.
Thank you for the answer! Have I broken the rule "Introduction of a method to a class or interface"? Should I create a new interface instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds getStoreUrl() method to app/code/Magento/Store/Block/Switcher.php
Modifies switcher-option's links in Magento/Store/view/frontend/templates/switch/stores.phtml and Magento/Store/view/frontend/templates/switch/languages.phtml templates
Fixed Issues (if relevant)
Contribution checklist