Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found 2 elements with non-unique id #email: magento 2 contact #14850

Closed
shivkumarsingh7 opened this issue Apr 25, 2018 · 8 comments
Closed

Found 2 elements with non-unique id #email: magento 2 contact #14850

shivkumarsingh7 opened this issue Apr 25, 2018 · 8 comments
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed up for grabs

Comments

@shivkumarsingh7
Copy link

Getting below error on Magento 2 contact page in console.

[DOM] Found 2 elements with non-unique id #email: (More info: https://goo.gl/9p2vKq)

<input name=​"email" id=​"email" title=​"Email" value class=​"input-text" type=​"email" data-validate=​"{required:​true, 'validate-email':​true}​" aria-required=​"true">​ 
<input name=​"username" id=​"email" type=​"email" class=​"input-text" data-bind=​"attr:​ {autocomplete:​ autocomplete}​" data-validate=​"{required:​true, 'validate-email':​true}​" autocomplete=​"off">​

screen shot 2018-04-25 at 7 18 12 pm

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed up for grabs good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Apr 25, 2018
@julienanquetil
Copy link
Contributor

Hi,
PR is done for 2.3-develop
2.2-develop is already done in commit : 781ec89
Thanks

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @shivkumarsingh7. Thank you for your report.
The issue has been fixed in #14867 by @julienanquetil in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@shivkumarsingh7
Copy link
Author

@julienanquetil thank you :)

@ishakhsuvarov
Copy link
Contributor

Closing this now, as it seems to be fixed in 2.3-develop and 2.2.4

@artskeem
Copy link

this is not fixed in 2.2.5 fyi -sorry

@milossh
Copy link

milossh commented Sep 2, 2018

@ishakhsuvarov This is still a bug in magento 2.2.5 .

@hostep
Copy link
Contributor

hostep commented Sep 2, 2018

@artskeem, @milossh: it is fixed in 2.2.4 and 2.2.5 on the contact page, I've just verified this on a vanilla installation.
Make sure you have no customisations done where it still uses a id="email" somewhere. Maybe you overwrite the authentication-popup.html file in your custom theme? Or maybe some 3rd party module inserts that somewhere?

@milossh
Copy link

milossh commented Sep 2, 2018

@hostep I have Porto theme, with latest patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed up for grabs
Projects
None yet
Development

No branches or pull requests

7 participants