Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: salesOrderItemRepository does not include gift message #19093

Closed
nthurston opened this issue Nov 6, 2018 · 18 comments
Closed

API: salesOrderItemRepository does not include gift message #19093

nthurston opened this issue Nov 6, 2018 · 18 comments
Assignees
Labels
Component: GiftMessage Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@nthurston
Copy link

Preconditions (*)

  1. Magento version 2.2.6
  2. REST API

Steps to reproduce (*)

  1. Place order with line level gift message
  2. Call GET /V1/orders/items/{id}

Expected result (*)

  1. Result should contain extension_attributes['gift_message'] element with gift message data

Actual result (*)

  1. Result does not contain gift_message element
@magento-engcom-team
Copy link
Contributor

Hi @nthurston. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@nthurston do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 6, 2018
@nthurston
Copy link
Author

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @nthurston. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nthurston, here is your Magento instance.
Admin access: http://34.228.235.121/i-19093-2-2-6//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@nthurston
Copy link
Author

Confirmed this on vanilla instance.

@ghost ghost self-assigned this Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 7, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Sales labels Nov 7, 2018
@ghost
Copy link

ghost commented Nov 7, 2018

Hi @nthurston, thank you for your report. Gift Wrapping available only on EE version. Please follow these guidelines for proper tracking of your issue. You can report Commerce-related issues in one of two ways:
You can use the Support portal associated with your account
or
If you are a Partner reporting on behalf of a merchant, use the Partner portal.

GitHub is intended for Magento Open Source users to report on issues related to Open Source only. There are no account management services associated with GitHub.

@ghost ghost closed this as completed Nov 7, 2018
@nthurston
Copy link
Author

I'm not talking about gift wrap, I'm talking about gift message.

Swagger shows that the gift message should be available on the order item API, it is not.

@ghost
Copy link

ghost commented Nov 7, 2018

@nthurston, ok wait a second.

@nthurston
Copy link
Author

nthurston commented Nov 7, 2018

If you're trying to say that Gift Message is not available in CE, that does not seem accurate.

CE Docs for 2.2
https://docs.magento.com/m2/2.2/ce/user_guide/sales/gift-options.html?Highlight=gift%20options

Options on a 2.2 CE instance
image

The module I am referring to is Magento\module-gift-message.

It should also be noted that the Order level gift message shows up fine in the Order API. The Item level message does not show up in the Order API or OrderItem API. There is no way to get the item level gift message through the API as far as I can tell.

@ghost ghost reopened this Nov 7, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: GiftMessage labels Nov 7, 2018
@ghost
Copy link

ghost commented Nov 7, 2018

@nthurston sorry Now i'm clear understand, that is the gift Message module

@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96184, MAGETWO-96185 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 7, 2018
@ghost ghost removed their assignment Nov 7, 2018
@larsroettig larsroettig self-assigned this Nov 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2019

Hi @lfolco. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@lfolco
Copy link
Contributor

lfolco commented Nov 25, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @lfolco. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lfolco, here is your Magento instance.
Admin access: https://i-19093-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

lfolco added a commit to lfolco/magento2 that referenced this issue Jan 4, 2020
@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 8, 2020
@VladimirZaets
Copy link
Contributor

Hi @nthurston. Thank you for your report.
The issue has been fixed in #25946 by @lfolco in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Jan 8, 2020
…9093) #25946

 - Merge Pull Request #25946 from lfolco/magento2:orderitem-giftmessage
 - Merged commits:
   1. 30b5818
   2. f076e55
lfolco added a commit to lfolco/magento2 that referenced this issue Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GiftMessage Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants