Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: i18n phrases with apostrophes (') in Knockout templates are untranslatable (and my fix) #1951

Closed
dmitrii-fediuk opened this issue Sep 25, 2015 · 2 comments
Closed

Bug: i18n phrases with apostrophes (') in Knockout templates are untranslatable (and my fix) #1951

dmitrii-fediuk opened this issue Sep 25, 2015 · 2 comments
Labels
bug report

Comments

@dmitrii-fediuk
Copy link

The bug description and my fix: https://mage2.pro/t/86
The bug is similar to #1905, but not the same.
@vkorotun vkorotun added the CS label Sep 28, 2015
@vkorotun vkorotun assigned vkorotun and unassigned vkorotun Sep 28, 2015
@piotrekkaminski
Copy link
Contributor

internal Issue ID MAGETWO-44053

magento-team pushed a commit that referenced this issue Oct 27, 2015
MAGETWO-44053: [GITHUB] Bug: i18n phrases with apostrophes (') in Kno…
3fa8b51 
…ckout templates are untranslatable (and my fix) #1951

- Added fix to account for phrases with apostrophes in ko templates.
@MomotenkoNatalia MomotenkoNatalia added PS and removed CS labels Dec 23, 2015
@MomotenkoNatalia
Copy link
Contributor

Internal ticket MAGETWO-44053 is closed and delivered to mainline. Please, let us know if you still have an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitrii-fediuk @piotrekkaminski @vkorotun @MomotenkoNatalia