Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment Issue when create a new email template admin. #19573

Closed
suryakant-krish opened this issue Dec 5, 2018 · 11 comments
Closed

Alignment Issue when create a new email template admin. #19573

suryakant-krish opened this issue Dec 5, 2018 · 11 comments
Assignees
Labels
Component: Theme Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@suryakant-krish
Copy link
Contributor

Preconditions (*)

  1. Magento 2.3

Steps to reproduce (*)

  1. Login into admin panel > Marketing > Email Templates > Create new Email template Load any default template. Current used For Alignment issue.

Expected result (*)

  1. https://prnt.sc/lqykjw

Actual result (*)

  1. https://prnt.sc/lqyjq4
@suryakant-krish suryakant-krish self-assigned this Dec 5, 2018
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@suryakant-krish do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost
Copy link

ghost commented Dec 5, 2018

Hi @suryakant-krish did you load some long breadcrumbs ?
selection_226

@ghost ghost added Progress: needs update Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 5, 2018
@suryakant-krish
Copy link
Contributor Author

Yes, I have load some long breadcrumbs.

@ghost
Copy link

ghost commented Dec 5, 2018

@suryakant-krish SO why you think this is a bug ?

@ghost ghost self-assigned this Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 5, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost
Copy link

ghost commented Dec 5, 2018

@suryakant-krish, I don't think that this is the good idea
selection_227

@suryakant-krish
Copy link
Contributor Author

Yes, you are absolutely right but when breadcrumb in single line alignment not proper.
I will work on that with other solution.

@ghost
Copy link

ghost commented Dec 5, 2018

@suryakant-krish margin-top: 6px;

@suryakant-krish
Copy link
Contributor Author

Yes, I have already applied it and added one more commit please review it.

@ghost ghost added Component: Theme Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: needs update labels Dec 5, 2018
@ghost ghost removed their assignment Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96964, MAGETWO-96965 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your report.
The issue has been fixed in #19574 by @suryakant-krish in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

2 participants