Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product title in asian language does not generate url key and permalink correctly #20879

Closed
thunderapps opened this issue Feb 1, 2019 · 10 comments
Labels
Component: CatalogUrlRewrite feature request Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@thunderapps
Copy link

thunderapps commented Feb 1, 2019

When adding a new product with non english text for the title field, it results in product permalink to be generated incorrectly. eg. /.html (empty name) and result in a 404.

Preconditions (*)

  1. Magento 2.1.6 CE (Bitnami)
  2. Web Server: Apache 2.4x Mod-rewrite enabled

Steps to reproduce (*)

  1. Add a new product, set title entirely in Asian language eg. Simplified Chinese or Japanese OR
  2. Seller adds a new product, set title entirely in Asian language eg. Simplified Chinese or Japanese
  3. Save

Expected result (*)

  1. Product should be saved and accessible via the front-end with a pretty URL name similar to the product title. eg. /物品.html

Actual result (*)

  1. URL-Key will be blank and unable to generate a pretty URL
  2. Clicking on the product link in the category page will direct to a 404. Pretty URL is displayed as "/.html" (blank name)
  3. url_rewrite table data are as follows:
    screen shot 2019-02-01 at 8 36 55 pm
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @thunderapps. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@thunderapps do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@thunderapps thunderapps changed the title Product title in asian language does not generate url key correctly Product title in asian language does not generate url key and permalink correctly Feb 1, 2019
@thunderapps
Copy link
Author

Tested with other asian languages, same result happens

@ghost ghost self-assigned this Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 1, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: CatalogUrlRewrite Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98023, MAGETWO-98024 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 1, 2019
@magento-engcom-team magento-engcom-team unassigned ghost Feb 1, 2019
@saphaljha saphaljha self-assigned this Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@milindsingh
Copy link
Member

https://github.com/studioraz/magento2-unicode-url

@saphaljha saphaljha removed their assignment Feb 3, 2019
@1ci
Copy link

1ci commented Feb 5, 2019

Is this fixed in the 2.3-dev branch yet? I really don't want to use an extension for such a core feature. I feel like it'll not be safe in the long run. Honestly, UTF-8 support should have been implemented years ago. OpenCart supports unicode URLs and crushes on SEO in this regard.

@orlangur
Copy link
Contributor

@thunderapps,

Product should be saved and accessible via the front-end with a pretty URL name similar to the product title. eg. /物品.html

Such expectation is wrong, the feature never existed in Magento 1 either and needs to be thoroughly evaluated prior to such system behavior change. As far as I remember, Magento is only able to convert product name into latin letters for some languages currently.

GitHub is intended for bug reports, please use https://github.com/magento/community-features for other suggestions like improvements or feature requests.

@orlangur orlangur added feature request and removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Mar 16, 2019
@hostep
Copy link
Contributor

hostep commented Mar 16, 2019

I just accidentally bumped into magento/magento2-jp#77, where they seem to work on adding support for this (for Japanese at least).

@orlangur
Copy link
Contributor

Great finding, @hostep! Surprised by transliterator in Japanese-specific module, I believe there were some in core for Greek or Cyrillic letters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogUrlRewrite feature request Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

7 participants