-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing comment element in core system.xml file can not be overwritten #21027
Comments
Hi @JanuszWitrykus. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @JanuszWitrykus do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
HI @JanuszWitrykus thank you for you report, i'm not able to reproduce following steps you described, please set the following ->
|
Hi @engcom-backlog-nazar , thank you very much for you effort. I have correct module.xml. And I can overwrite label element (always) but comment element only if it is empty in the core module. |
Hi @magento-engcom-team @engcom-backlog-nazar can you please reopen this issue? I have tested it on several Magento instances, this is simple to reproduce. |
✅ Confirmed by @engcom-backlog-nazar Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @Renu05. Thank you for working on this issue.
|
Hi @JanuszWitrykus , I have created a custom module to change the system.xml comment text and the text got successfully updated in This has been tested in Magento 2.3.3 CE version
Hence this is not an issue so closing the ticket. |
@Renu05 Thank you very much for your effort, but can you tell me please, why did you close this bug? In Preconditions I said, that this bug exists in Magento 2.2.7. Have we any patch to fix this bug in 2.2.7? Please, don't test in in 2.3.x, this report does not apply to the version 2.3.x. I hope, that M 2.2.7 is still supported :) @magento-engcom-team Can you please confirm, that we have patch to fix this bug in 2.2.x? If not, maybe it can be still open to wait on solution? |
Preconditions (*)
Steps to reproduce (*)
In custom module I try to overwrite comment field from core module in which comment already exists, like this (in system.xml, module has set correct sequence):
`
...
<system>
<section id="currency">
<group id="options">
<field id="base" translate="label comment" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
<comment>
<![CDATA[Base market currency]]>
</comment>
...
`
Core module:
Magento_Directory, version 100.2.6
Expected result (*)
Comment field should be overwritten and visible in admin as "Base market currency"
Actual result (*)
Comment field is not overwritten and visible in admin as "Base currency is used for all online payment transactions. The base currency scope is defined by the catalog price scope ("Catalog" > "Price" > "Catalog Price Scope")."
The text was updated successfully, but these errors were encountered: