Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php bin/magento setup:db-declaration:generate-whitelist command does not work when Magento install with prefix #23032

Closed
sanjay-wagento opened this issue May 28, 2019 · 7 comments
Assignees
Labels
Component: Setup Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release WIP Work In Progress

Comments

@sanjay-wagento
Copy link
Contributor

Preconditions (*)

  1. Install Magento 2.3.1 with the prefix

Steps to reproduce (*)

  1. Install Magento 2.3.1 with the prefix
  2. Run php bin/magento setup:db-declaration:generate-whitelist --module-name=Magento_Catalog command

Expected result (*)

  1. Command must work and create db_schema_whitelist.json file

Actual result (*)

  1. It gives Magento was installed with a table prefix. Please re-install without prefix. message
@m2-assistant
Copy link

m2-assistant bot commented May 28, 2019

Hi @sanjay-wagento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sanjay-wagento do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 28, 2019
@Den4ik Den4ik self-assigned this Jun 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2019

Hi @Den4ik. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.
    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

@Den4ik Den4ik added Component: Setup Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 11, 2019
@ghost ghost unassigned Den4ik Sep 11, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 11, 2019
@magento-engcom-team
Copy link
Contributor

@Den4ik Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@Den4ik Den4ik added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 11, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Den4ik
Thank you for verifying the issue. Based on the provided information internal tickets MC-20114 were created

Issue Available: @Den4ik, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 11, 2019
@Den4ik Den4ik self-assigned this Sep 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 11, 2019

Hi @Den4ik. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@Den4ik Den4ik added the WIP Work In Progress label Sep 11, 2019
@buskamuza
Copy link
Contributor

This is expected behavior. The whitelist should be generated on dev environment by the extension developer, so it should not be necessary to support DB with prefix.
Presence of the prefix impacts names of DB entities (such as names of keys), and such names can't be used in the generated whitelist.
The whitelist is a temporary solution while we're migrating from old setup scripts to the declarative schema, and in the future will be eliminated (together with the whitelist command).

@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 1, 2019

Hello @sanjay-wagento and @Den4ik

Thank you for contribution and collaboration!

Based on feedback from the Magento Architecture team it is not a bug.
Please see this #23032 (comment) for more details and explanation.

I'm closing this issue

@sdzhepa sdzhepa closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setup Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release WIP Work In Progress
Projects
None yet
Development

No branches or pull requests

5 participants