Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer navigation displaying whenever select Static Block onl #24031

Closed
ankitpatel2931 opened this issue Aug 6, 2019 · 13 comments
Closed

Layer navigation displaying whenever select Static Block onl #24031

ankitpatel2931 opened this issue Aug 6, 2019 · 13 comments
Assignees
Labels
Component: LayeredNavigation Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ankitpatel2931
Copy link

ankitpatel2931 commented Aug 6, 2019

Preconditions (*)

  1. Magento 2.3.2
  2. Sample data installed

Steps to reproduce (*)

  1. Set Display Mode to Static block only on particular category
    Hoodies   Sweatshirts (ID_ 15) _ Categories _ Inventory _ Catalog _ Magento Admin (1)

Expected result (*)

  1. Layered Navigation (Shopping Options) should not be visible
    Hoodies   Sweatshirts - Tops - Men (3) (1)

Actual result (*)

  1. Layered Navigation (Shopping Options) visible
    Hoodies   Sweatshirts - Tops - Men (2)
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2019

Hi @ankitpatel2931. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ankitpatel2931 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@engcom-Bravo engcom-Bravo self-assigned this Aug 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hello @ankitpatel2931, thanks for applying. The Display Mode has three available options: Products only, Static block only and Static block and products. Seems each option works as expected. There is no option with Layered Navigation and the Layered Navigation itself is not a part and parcel of the product list. If You want the Layered Navigation to stop displaying on that category page You may for example change its display setting of Anchor from Yes to No.

@ankitpatel2931
Copy link
Author

Hello,

Thanks for the update here.

As I have checked in previous version like magento 2.2.5
It's working fine. Please see below file and below code.

/vendor/magento/module-layered-navigation/Block/Navigation.php

/**
* Check availability display layer block
*
* @return bool
*/
public function canShowBlock()
{
return $this->getLayer()->getCurrentCategory()->getDisplayMode() !== \Magento\Catalog\Model\Category::DM_PAGE
&& $this->visibilityFlag->isEnabled($this->getLayer(), $this->getFilters());
}

Above things working fine.

But, in Magento 2.3.2 above function looks like below.

/**
* Check availability display layer block
*
* @return bool
*/
public function canShowBlock()
{
return $this->visibilityFlag->isEnabled($this->getLayer(), $this->getFilters());
}

If I replaced above code with Magento 2.2.5 code than every thing works fine.

I think, I am selecting Static Block here. So, I don't want to display Products in this page. So, no need to display Layer navigation when I select Static Block.

Could you please confirm both function?

Thanks.

@engcom-Bravo engcom-Bravo added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Aug 7, 2019
@engcom-Bravo
Copy link
Contributor

Initially the same issue #7765 was reported on 2.1.2 version. Then fixed in 2.2 by commit 39e0fd9 but seems that commit was not merged into 2.3.

@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 7, 2019
@ghost ghost unassigned engcom-Bravo Aug 7, 2019
@magento-engcom-team
Copy link
Contributor

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 7, 2019
@engcom-Bravo engcom-Bravo added Component: LayeredNavigation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 7, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 7, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-19005 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Bravo engcom-Bravo removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update labels Aug 7, 2019
@ankitpatel2931
Copy link
Author

ankitpatel2931 commented Aug 7, 2019

Hi @engcom-Bravo , @magento-engcom-team ,

Thanks for confirmation.
Please let me know If I can do any thing in this.

@engcom-Bravo
Copy link
Contributor

You are welcome @ankitpatel2931. I think You've already done enough, so thanks for help.

@shikhamis11 shikhamis11 self-assigned this Aug 12, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2019

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@mahesh-rajawat mahesh-rajawat self-assigned this Aug 31, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2019

Hi @maheshWebkul721. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@ghost ghost assigned mahesh-rajawat Sep 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ankitpatel2931. Thank you for your report.
The issue has been fixed in #24497 by @maheshWebkul721 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 12, 2019
@BezV8
Copy link
Contributor

BezV8 commented Feb 14, 2020

The fix included in 2.3.4 has fixed the issue on most categories for me, but a few seem to still exhibit the buggy behaviour. All of those with the layered navigation still showing all also have anchor set to no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: LayeredNavigation Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants