The 'promotion' region of the minicart is never rendered

[mattijv]

Preconditions (*)

1. M2.3.1 or later (and possibly some later M2.2 versions too)

Steps to reproduce (*)

1. Add a component to the 'promotion' region of the minicart jsLayout

Expected result (*)

1. Component is rendered

Actual result (*)

1. Component is not rendered

Cause

The issue was introduced in #20383 where an if-binding was added to the minicart-widgets div to prevent the div from being rendered if the 'promotion' region does not contain any elements. Unfortunately the if was written badly as the conditional is checking the length property of the observable returned from getRegion (always 0) instead of the array contained in the observable. This means the conditional is always false and the element is never rendered.

Possible fixes

I've create two mutually exclusive PR's that solve the issue in two ways.

#25374 Fixes the if-clause by adding the missing parentheses.

#25375 Is a bit more involved fix as it adds a separate method to the collection component that can be used to check if a region contains elements. It also modifies existing uses of the getRegion(region)().length pattern to use the new method.

[m2-assistant]

Hi @mattijv. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@mattijv do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[VladimirZaets]

Hi @mattijv. Thank you for your report.
The issue has been fixed in #25375 by @mattijv in 2.4-develop branch
Related commit(s):

• 20d3f40795e8c29aa1a307c55817f557698f2f8a
• 9b6c8d74daf13a1de3124d6999751f158004f2b2
• ca8c75a303918257d1fca4cc110ad7348b05a72f
• f9eb4e4c0867eeb8adee181ca6137bfc43cc1fed
• 109392d8d78f6ada85e13f1523537888a66e8da0

The fix will be available with the upcoming 2.4.0 release.