Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree payment credit card 3d secure billing surname special characters #25483

Open
hugoruivo opened this issue Nov 6, 2019 · 17 comments
Open
Labels
Area: Payments CD Issue recommended for the contribution day Component: Braintree Component: Sales Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@hugoruivo
Copy link

hugoruivo commented Nov 6, 2019

Preconditions (*)

  1. Magento Version 2.3.3
  2. Braintree Credit card setup as payment method with 3D Secure Verification enabled

Steps to reproduce (*)

  1. Add a product to the cart
  2. Go to checkout
  3. In the shipping address set the First Name with special characters ( Tést )
  4. In the shipping address set the Last Name with special characters ( Tést )
  5. In the payment method select Credit Card
  6. Ensure that the "My billing and shipping address are the same" is checked
  7. Insert card details
  8. Click Place Order
  9. Nothing happens

Expected result (*)

  1. Open braintree payment process

Actual result (*)

  1. An error is printed to the browser console
  2. Checking the network tab of the braintree api we get the following:
    {"error":{"message":"Billing given name format is invalid.\nBilling surname format is invalid."},"threeDSecureInfo":{"liabilityShifted":false,"liabilityShiftPossible":false}}
@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2019

Hi @hugoruivo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hugoruivo do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 6, 2019
@hugoruivo
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hugoruivo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hugoruivo, here is your Magento instance.
Admin access: https://i-25483-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hugoruivo
Copy link
Author

I'm able to replicate this issue @ https://i-25483-2-3-develop.instances.magento-community.engineering/admin

@hugoruivo hugoruivo changed the title Braintree payment credit card billing surname special characters Braintree payment credit card 3d secure billing surname special characters Nov 6, 2019
@ajijshekh123 ajijshekh123 self-assigned this Nov 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2019

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 added Component: Braintree Component: Sales Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 6, 2019
@ajijshekh123
Copy link

I have verified this issue in your First and last name value. But I can't reproduce this issue.
I am using the Braintree Sandbox Payment configuration in the admin section on Magento 2.3 instance.
Please see the attached video:

BraintreePayment_Issue

@hugoruivo - Can you please send me the video or any other helpful details to reproduce this issue?
I think some issues with your Braintree configuration.
If you have not found again this issue let me know so I will close this issue.

Thanks.

@ajijshekh123 ajijshekh123 added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Nov 6, 2019
@hugoruivo
Copy link
Author

@ajijshekh123 You need to have 3D Secure Verification enabled on the braintree configuration.
Configuration___Settings___Stores___Magento_Admin

@ajijshekh123
Copy link

Okay @hugoruivo

@ajijshekh123 ajijshekh123 added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Nov 6, 2019
@ajijshekh123
Copy link

@hugoruivo - I have reproduced this issue when I have enabled the 3D Secure verification on Braintree payment configuration.
Thanks for the update.
See attached the video:

BraintreePayment_Issue_Reproduced

@ajijshekh123 ajijshekh123 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 6, 2019
@ghost ghost unassigned ajijshekh123 Nov 6, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 6, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-22857 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@bst2002git
Copy link

bst2002git commented Nov 14, 2019

Hello i can reproduce this Error using 3DS enabled and this name in german (field with non-ascii ) "Hr. Ronny Schönberger".
If you replace (for debugging) the umlaut "ö" with "oe" it works.
Using Magento 2.3.3 (braintreeLibraryVersion | braintree/web/3.48.0)

JSON-Request sent from Magento:
URL: https://api.sandbox.braintreegateway.com/merchants/xxxx/client_api/v1/payment_methods/tokenXXXX/three_d_secure/lookup
POST-Param:
{"amount":18.75,"additionalInfo":{"shippingGivenName":"Ronny","shippingSurname":"Schönberger","shippingPhone":"+430316 123456789","billingLine1":"Giga-Gasse 61","billingCity":"Maltschach","billingState":null,"billingPostalCode":"9820","billingCountryCode":"AT","billingPhoneNumber":"+430316 123456789","billingGivenName":"Ronny","billingSurname":"Schönberger","shippingLine1":"Giga-Gasse 61","shippingCity":"Maltschach","shippingState":null,"shippingPostalCode":"9820","shippingCountryCode":"AT"},"dfReferenceId":"0_15fe3003-53bb-4767-bd75-781231c2bdc3","clientMetadata":{"sdkVersion":"web/3.48.0","requestedThreeDSecureVersion":"2","cardinalDeviceDataCollectionTimeElapsed":344},"authorizationFingerprint":"...","braintreeLibraryVersion":"braintree/web/3.48.0","_meta":{"merchantAppId":"develshop.fangocur.at","platform":"web","sdkVersion":"3.48.0","source":"client","integration":"custom","integrationType":"custom","sessionId":"a7816h40-92f1-4263-bbfa-4217fgf8fjfec"}}

Response:
{"error":{"message":"Billing surname format is invalid."},"threeDSecureInfo":{"liabilityShifted":false,"liabilityShiftPossible":false}}

@franckgarnier21
Copy link

Hello,

Any update or information where we can apply an hotfix ?

Thanks,

@hugoruivo
Copy link
Author

Hi,

I ended up doing a "dirty" quick fix for this.

By doing an override of: "Magento_Braintree/js/view/payment/3d-secure"

Then removing Special characters on the billingAddress givenName and surname from the validate function ( when I say removing it means changing the special char to the ASCII equivalent ex: ó -> o ).

@bst2002git
Copy link

bst2002git commented Jun 23, 2020

Hello this is the answer i get from Braintree-Support:

The error you are receiving, 94350 - Billing surname format is invalid​, is generally thrown when diacritics are included. ​The accepted characters to pass in these parameters are ASCII printable characters. This limitation is set by our MPI provider Cardinal Commerce as it is an EMVco standard.

Thus far, there are two solutions:

  1. You'd need to convert any non-ASCII characters - the issue here is that there aren't always direct matches from ñ to n​ so you could accidentally make mismatches between supplied names similar to your example with æ​ and changing it to ae​.

  2. You could add a check on your client for any non-ASCII characters and inform the customer thusly. This way, it's in the customer's control to change the letters.

See also: braintree/braintree-web-drop-in#536

bst2002git added a commit to bst2002git/magento2 that referenced this issue Jun 24, 2020
bst2002git added a commit to bst2002git/magento2 that referenced this issue Jun 24, 2020
@ghost ghost assigned bst2002git Jun 24, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Jun 24, 2020
bst2002git added a commit to bst2002git/magento2 that referenced this issue Jun 24, 2020
@bst2002git
Copy link

Hello, my be it is better to provide an Input-Field for Credit Card-Holder Name (see Example Image)

CC_name_input_field

@ghost ghost added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 18, 2020
@ghost ghost unassigned bst2002git Sep 9, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Sep 9, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@sidolov sidolov added this to Ready for Development in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Dev in Community Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Development in Low Priority Backlog Oct 20, 2020
@JoaoFerreiraEla
Copy link

3d-secure

I'm facing the same issue, can you show me how you achieved this please?

Thanks in advance !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Payments CD Issue recommended for the contribution day Component: Braintree Component: Sales Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests

9 participants