Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle product with option type radio and dropdown can be added to the cart with multiple choices #26110

Closed
TomashKhamlai opened this issue Oct 31, 2019 · 13 comments · Fixed by #29256
Assignees
Labels
Component: Bundle Component: BundleGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Milestone

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Oct 31, 2019

Preconditions (*)

  1. Sample Data

Steps to reproduce (*)

  1. Add product to the cart
mutation addBundle(
  $cart_id: String!
) {
  addBundleProductsToCart(
    input: {
      cart_id: $cart_id
      cart_items: {
        data: {
          quantity: 1
          sku: "24-WG080"
        }
        bundle_options: [
          {
            id: 1
            quantity: 1
            value: [
              "1"
              "2"
              "3"
            ]
          }
          {
            id: 2
            quantity: 1
            value: [
              "4"
            ]
          }
                    {
            id: 3
            quantity: 1
            value: [
              "5"
            ]
          }
                    {
            id: 4
            quantity: 1
            value: [
              "8"
            ]
          }
        ]
      }
    }
  ) {
    cart {
      items {
        id
        quantity
        product {
          sku
        }
        ... on BundleCartItem {
          bundle_options {
            id
            label
            type
            values {
              id
              label
              quantity
              __typename
            }
          }
        }
      }
    }
  }
}

Expected result (*)

  1. Some message that complains about invalid input for BundleItem.type: radio/dropdown

Actual result (*)

  1. Successfully added to cart

Additional information

The issue was confirmed again on the lates 2.4-develop code. May 28, 2020
In general it is possible to add to Shopping Cart and place order with option type radio and dropdown with multiple choices. This flow is not possible using UI on Storefront.
More details: #26110 (comment)

@sedonik sedonik self-assigned this Dec 11, 2019
@sedonik
Copy link
Contributor

sedonik commented Dec 12, 2019

Hi @TomashKhamlai,

There were not be able to reproduce.
There is an error:

Magento\\\\Framework\\\\GraphQl\\\\Schema\\\\Type\\\\Output\\\\ElementMapper\\\\Format' in '\\/var\\/www\\/magento2\\/graphql\\/pub\\/lib\\/internal\\/Magento\\/Framework\\/GraphQl\\/Schema\\/Type\\/ScalarTypes.php' on line 23\",\"trace\":\"Trace is not available.\"}]}}"

Was tested in magento/graphql-ce branch: 2.3-develop

Could you advise?

@TomashKhamlai
Copy link
Contributor Author

I will try.

@sedonik
Copy link
Contributor

sedonik commented Dec 13, 2019

Hi @TomashKhamlai,

Sorry, I've made:

composer install

and

composer update

and this Error was gone.
Continue investigating.

@lenaorobei lenaorobei transferred this issue from magento/graphql-ce Dec 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @TomashKhamlai. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@TomashKhamlai do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@lenaorobei lenaorobei added Component: Bundle Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 18, 2019
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Dec 18, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @lenaorobei
Thank you for verifying the issue. Based on the provided information internal tickets MC-29908 were created

Issue Available: @lenaorobei, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sedonik sedonik self-assigned this Dec 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @sedonik. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@sedonik
Copy link
Contributor

sedonik commented Dec 18, 2019

Hi @lenaorobei,

I've created PR #26122
Could you check is it implemented correctly?

Thanks.

@lenaorobei
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, here is your Magento instance.
Admin access: https://i-26110-2-4-develop.instances.magento-community.engineering/admin_7b6b
Login: 79ed051f Password: 9a178b5c48e9
Instance will be terminated in up to 3 hours.

@sdzhepa sdzhepa added Component: BundleGraphQl Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels May 27, 2020
@chalov-anton
Copy link
Contributor

chalov-anton commented May 28, 2020

Rechecked on the latest Magento 2.4-develop

The issue is still reproducible.
I can successfully perform the following mutations:

1. addBundleProductsToCart
2. setBillingAddressOnCart
3. setShippingAddressesOnCart
4. setShippingMethodsOnCart
5. setPaymentMethodOnCart 

and Place the order

mutation {
  placeOrder(input: {cart_id: "AgfUXQZms2gu5SUTPHRvisT8VnzPLdF5"}) {
    order {
      order_number
    }
  }
}

response: 
{
  "data": {
    "placeOrder": {
      "order": {
        "order_number": "000000003"
      }
    }
  }
}

The order is created in Admin Panel
order_admin

Admin can successfully:

  1. Send Email
  2. Invoice
  3. Ship
    and Complete the order
    order_admin_complete

@nrkapoor nrkapoor added this to the 2.4.1 milestone May 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 28, 2020

Hi @danielrenaud. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@lenaorobei lenaorobei added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 28, 2020
@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog Jun 20, 2020
@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 20, 2020
@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog Jun 24, 2020
@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 24, 2020
@michalderlatka michalderlatka self-assigned this Jul 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2020

Hi @michalderlatka. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jul 23, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jul 24, 2020
michalderlatka pushed a commit to michalderlatka/magento2 that referenced this issue Jul 30, 2020
michalderlatka pushed a commit to michalderlatka/magento2 that referenced this issue Aug 5, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Bundle Component: BundleGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
9 participants