Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class \Magento\Framework\Data\Form\Element\Fieldset breaks specification of the parent class \Magento\Framework\Data\Form\Element\AbstractElement by not calling the method getBeforeElementHtml (getAfterElementHtml is called) #2618

Closed
dmitrii-fediuk opened this issue Dec 5, 2015 · 5 comments
Closed

Class \Magento\Framework\Data\Form\Element\Fieldset breaks specification of the parent class \Magento\Framework\Data\Form\Element\AbstractElement by not calling the method getBeforeElementHtml (getAfterElementHtml is called) #2618

dmitrii-fediuk opened this issue Dec 5, 2015 · 5 comments
Assignees
@vasilii-b
Labels
Area: Frontend bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dmitrii-fediuk
Copy link

https://mage2.pro/t/248

See also: #2202, #2615
@shiftedreality
Copy link
Member

Hi @dfediuk

Internal ticket MAGETWO-47934 was created for this issue

@victorgugo victorgugo added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 14, 2016
@vkorotun vkorotun removed the PS label Aug 4, 2016
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 25, 2017
@magento-engcom-team
Copy link
Contributor

@dmitry-fedyuk, thank you for your report.
We've created internal ticket(s) MAGETWO-47934 to track progress on the issue.

magento-engcom-team pushed a commit that referenced this issue May 30, 2018
@viktym
Merge pull request #2618 from magento-mpi/MPI-PR
9d6930c 
[MPI] Bug Fixes
magento-engcom-team pushed a commit that referenced this issue Aug 2, 2018
@viktym
Merge pull request #2954 from magento-mpi/port-2618
8ad9684 
[MPI] Forward port #2618
@vasilii-b vasilii-b self-assigned this Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@vasilii-b vasilii-b mentioned this issue Oct 25, 2018
Merged
4 tasks
@vasilii-b vasilii-b added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 25, 2018
@okorshenko
Copy link
Contributor

Hi @dmitry-fedyuk. Thank you for your report.
The issue has been fixed in #18798 by @vasilii-b in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 31, 2018
@vasilii-b vasilii-b mentioned this issue Nov 1, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @dmitry-fedyuk. Thank you for your report.
The issue has been fixed in #18985 by @vasilii-b in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasilii-b vasilii-b

Labels
Area: Frontend bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dmitrii-fediuk @victorgugo @shiftedreality @wert2all @okorshenko @vkorotun @MomotenkoNatalia @vasilii-b @magento-engcom-team