Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin config section not expanded when fields are required. #26427

Closed
qsolutions-pl opened this issue Jan 17, 2020 · 10 comments · Fixed by #28285
Closed

Admin config section not expanded when fields are required. #26427

qsolutions-pl opened this issue Jan 17, 2020 · 10 comments · Fixed by #28285
Assignees
Labels
Component: Backend Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers Triage: Ready for Triage Issue is ready to me triaged with Product Manager

Comments

@qsolutions-pl
Copy link
Contributor

Preconditions (*)

  1. Magento 2.3.3 / 2.3.2 Open Source

Steps to reproduce (*)

  1. Create a new module that adds new system configuration
  2. In this system configuration add 2 group of fields
  3. For first group make all fields not required
  4. For second group make at least 1 field required
  5. Go to that section in admin panel
  6. Make sure both sections are not expanded (by default they should not be)
  7. Try to save system config

Expected result (*)

  1. System should expand tab with required fields and scrolls to it / them

Actual result (*)

  1. Nothing happens, from customer / UX point of view system hangs and there is no error message
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @qsolutions-pl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@qsolutions-pl do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 17, 2020
@shikhamis11 shikhamis11 self-assigned this Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Backend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 18, 2020
@ghost ghost unassigned shikhamis11 Jan 18, 2020
@shikhamis11 shikhamis11 self-assigned this Jan 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 18, 2020

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 21, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-30623 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2020

Hi @vikalps4. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@qsolutions-pl
Copy link
Contributor Author

@sdzhepa this is in progress for 28 days, any update?

@qsolutions-pl
Copy link
Contributor Author

@sdzhepa another 14 days have passed, how is progress on this task? @magento-engcom-team can I have any update on this?

@sdzhepa
Copy link
Contributor

sdzhepa commented May 7, 2020

Hello @qsolutions-pl

I just set label Dev In Progress because

vikalps4 self-assigned this on Jan 27

But seems @vikalps4 is not working on it and I can unassign him
So, this issue is ready for development - feel free to propose PR with fix

@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog May 7, 2020
@Bartlomiejsz
Copy link
Contributor

@magento I am working on this

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue May 19, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog May 19, 2020
@ghost ghost removed the Progress: ready for dev label May 19, 2020
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Jun 10, 2020
@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers labels Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @qsolutions-pl. Thank you for your report.
The issue has been fixed in #28285 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 21, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jul 21, 2020
magento-engcom-team added a commit that referenced this issue Jul 21, 2020
…ds are required. #28285

 - Merge Pull Request #28285 from Bartlomiejsz/magento2:feature/fix_26427_admin_config_section_not_expanded
 - Merged commits:
   1. a7fa47b
   2. c842d73
   3. 9d70a32
   4. ac5ce56
@magento-engcom-team magento-engcom-team added the Reported on 2.3.2 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers Triage: Ready for Triage Issue is ready to me triaged with Product Manager
Projects
Development

Successfully merging a pull request may close this issue.

6 participants