Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong gallery behavior when query url param configurable product #26858

Closed
sergiy-v opened this issue Feb 13, 2020 · 12 comments · Fixed by #26560
Closed

Wrong gallery behavior when query url param configurable product #26858

sergiy-v opened this issue Feb 13, 2020 · 12 comments · Fixed by #26560
Assignees
Labels
Component: ConfigurableProduct Component: Image Component: Url Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@sergiy-v
Copy link
Contributor

sergiy-v commented Feb 13, 2020

Wrong gallery behavior for preselected option by query url param for configurable product.

Preconditions

  1. Magento 2.4

Steps to reproduce

  1. Create a configurable product (the color attribute uses for example) with associated products:
  • product with 'Black' color
  • product with 'White' color
  1. Add image and video for each products like on the screenshot below.

Screen Shot 2020-02-13 at 11 36 56 AM

  1. Add needed params to product URL to preselected option.
    For example
  • http://store.com/configurable-b.html#93=4 where 93 - is color attribute id and 4 - 'white' option id
  • http://store.com/configurable-b.html#93=5 where 93 - is color attribute id and 5 - 'black' option id

Expected result

  1. For URL with query to preselect 'white' option.

Screen Shot 2020-02-13 at 2 03 43 PM

  1. For URL with query to preselect 'black' option.

Screen Shot 2020-02-13 at 2 01 08 PM

Actual result

  1. For URL with query to preselect 'white' option.

Screen Shot 2020-02-13 at 1 55 56 PM

  1. For URL with query to preselect 'black' option.

Screen Shot 2020-02-13 at 1 53 42 PM

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @sergiy-v. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sergiy-v do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@sergiy-v sergiy-v self-assigned this Feb 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @sergiy-v. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @Leandry. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sergiy-v sergiy-v removed their assignment Feb 13, 2020
@Leandry Leandry added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: ConfigurableProduct Component: Image Component: Url labels Feb 13, 2020
@Leandry
Copy link

Leandry commented Feb 13, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Leandry. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Leandry, here is your Magento instance.
Admin access: https://i-26858-2-4-develop.instances.magento-community.engineering/admin_6afb
Login: 4f18cd1e Password: 8f208541171f
Instance will be terminated in up to 3 hours.

@Leandry Leandry added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 13, 2020
@ghost ghost unassigned Leandry Feb 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 13, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Leandry
Thank you for verifying the issue. Based on the provided information internal tickets MC-31480 were created

Issue Available: @Leandry, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @sergiy-v. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@rani-priya
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rani-webkul, here is your Magento instance.
Admin access: https://i-26858-2-4-develop.instances.magento-community.engineering/admin_e54d
Login: b8fa97fb Password: b6c25bc07745
Instance will be terminated in up to 3 hours.

sergiy-v pushed a commit to sergiy-v/magento2 that referenced this issue Feb 28, 2020
…for swatches, 'product image updating' for dropdown type, added MFTF tests to cover all cases: magento#26473, magento#26856, magento#26858
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sergiy-v. Thank you for your report.
The issue has been fixed in #26560 by @sergiy-v in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ConfigurableProduct Component: Image Component: Url Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants