Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Action log doesn't log before change value? #26943

Closed
shashank9044 opened this issue Feb 20, 2020 · 9 comments
Closed

Admin Action log doesn't log before change value? #26943

shashank9044 opened this issue Feb 20, 2020 · 9 comments
Assignees
Labels
Component: Admin Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@shashank9044
Copy link

shashank9044 commented Feb 20, 2020

Preconditions (*)

Magento 2.3.4 vanilla installation, we faced issue in Action Logging, Action Log only shows the result after change column not in before change column, before change column it shows N/A.

The values in the column Value Before Change always have N/А values regardless of whether this is the first change or the next, or when the default value is returned.

Steps to reproduce (*)

  1. Login to admin
  2. Stores ->configuration ->save any config entry from configuration page for example :
    Customers->Password option -> Password Reset type protection ->select email
  3. Save the configuration.
  4. Then Click System-> Under Action and log section ->click on Reports->Click latest save Action ->view
  5. Here you can see before change value is missing which shows N/A

Expected result (*)

  1. Expected is to show before change value as After change value shown already .

Actual result (*)

1.Actually before change value always shows showing N/A.
Screenshot 2020-02-20 at 13 51 27

@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @shashank9044. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@shashank9044 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 20, 2020
@magento-deployment-service
Copy link

Hi @m2-assistant[bot] Here is your new Magento Instance: https://i-26943-2-4-develop.magento-testing-service.engineering
Admin access: https://i-26943-2-4-develop.magento-testing-service.engineering/admin_1ee3
Login: 1e47b2d7, Password: 8dd8806e474e

@AnnaShepa AnnaShepa self-assigned this Feb 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @AnnaShepa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@AnnaShepa AnnaShepa added Component: Admin Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Feb 20, 2020
@ghost ghost unassigned AnnaShepa Feb 20, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @AnnaShepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-31717 were created

Issue Available: @AnnaShepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 20, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 20, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-26943-2-4-develop.instances.magento-community.engineering/admin_ea59
Login: 7c0e8d42 Password: 1345b57de2af
Instance will be terminated in up to 3 hours.

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @bgorski. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@bgorski
Copy link
Contributor

bgorski commented Apr 3, 2020

Status update: work still in progress

@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels May 1, 2020
@sdzhepa sdzhepa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels May 4, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Archived in project
Development

No branches or pull requests

5 participants